-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all remaining self-check errors #521
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
45757f7
Copy af_maybe() from erlang/otp#7013
erszcz fc54501
Fix a self-check error in gradualizer_db:get_beam_map/0
erszcz b990d6b
Fix a self-check error in typechecker:compat_ty(record, record, ...)
erszcz fc1c5b4
Fix a self-check error in compat_ty(tuple, tuple, ...)
erszcz ef6750c
Fix a self-check error in compat_ty(map, map, ...)
erszcz 10d5f64
Fix a self-check error in compat_ty(map_assoc, map_assoc, ...)
erszcz 4bb2090
Fix a self-check error in absform:normalize_function_type/1
erszcz 1b8046d
Add a TODO about solving constraints
erszcz b934fc3
Fix a self-check error in gradualizer_int:int_type_to_range/1
erszcz 5efbb02
Fix a self-check error in gradualizer_lib:get_type_definition/3
erszcz 1c8d073
Fix a self-check error in gradualizer_int:int_range_to_types/1
erszcz edab7d3
Fix a self-check error in normalize_rec/2 and expand_builtin_aliases/1
erszcz 48962db
Fix a self-check error in compat_ty/4
erszcz 3863915
Fix a self-check error in expect_fun_type1/3
erszcz 57a07c2
Fix a self-check error in type_check_list_op_in/3 and add test/should…
erszcz 5a68b96
Fail CI if ERROR_LINES is non-zero
erszcz 3e31239
Explain gradualizer_type.erl direct inheritance from OTP's erl_parse.yrl
erszcz 49e695b
Add a test for the solver 'shape sensitivity' to test/known_problems/…
erszcz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't want the user to see which command we're running?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's connected with how we count lines in the CI self-check assessment (see changes to
.github/workflows/self-check.yml
in this PR). We cannot rely on the status code, because we ignore some trivial errors withgrep -v
and the status code always reflects failure. We check the number of error lines instead. If we print the command, we have to assume that exactly 2 lines means "no errors", which is a bit strange. If we do not print the command, 0 error lines means "no errors", i.e. a success.All in all, it's a detail. The user can still see the command in the Makefile.