Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and examples for pool.terminate. #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mramato
Copy link

@mramato mramato commented Mar 10, 2019

pool.terminate returns a Promise, but the documentation and examples treated it as if it were synchronous.

Fixes #56

`pool.terminuate` returns a Promise, but the documentation and examples
treated it as if it were synchronous.

Fixes josdejong#56
@josdejong
Copy link
Owner

Before merging this PR, I think we first have to actually implement the async termination, we discovered that's not yet the case 🙄 , see #32

maybephilipp pushed a commit to maybephilipp/workerpool that referenced this pull request Sep 27, 2020
Co-authored-by: Aleksey Gerasimov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants