Added support for stdout and stderr options #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybephilipp
force-pushed
the
adding-stdout-stderr-options
branch
from
a9a9b79
to
0ecdcee
Compare
|
Thanks Philipp for your PR. Makes sense to be able to control the output of workers. Can you please write some documentation in the README about these two new options and how to use it? And write a unit test validating that the functionality works? |
Yeah, okay:) |
|
Hi philipp, it's an old PR but still usefull, can you take time to update your PR with documentation ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need support for hiding stdout and stderr in my project for Workers. I've added options to WorkerPool to support them.