Skip to content

Fix for #2919 option 1 #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

Maxim-Mazurok
Copy link
Contributor

@Maxim-Mazurok Maxim-Mazurok commented Apr 9, 2023

Gets rid of named exports

Potentially breaks extensions as we can no longer use this:

declare module 'mathjs' {
  interface MathJsStatic {
    testFun(): number
    value: number
  }
}

{
  const math = create(all, {})
//...

and have to use this instead:

interface MyMathJsStatic extends mathjs.MathJsStatic {
  testFun(): number
  value: number
}

{
  const math = mathjs.create(mathjs.all, {}) as MyMathJsStatic
//...

@josdejong
Copy link
Owner

See #2919 (comment)

@josdejong josdejong closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants