Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use env to set GOPATH for shells like Fish. #33

Merged
merged 2 commits into from
Aug 23, 2019
Merged

Use env to set GOPATH for shells like Fish. #33

merged 2 commits into from
Aug 23, 2019

Conversation

oncomouse
Copy link
Contributor

In a shell such as fish, trying to install gopls and gomodifytags produces the following errors:

fish: Unsupported use of '='. To run 'go' with a modified environment, please use 'env GOPATH=/Users/xxx/.config/coc/extensions/coc-go-data/tools go…'
GOPATH=/Users/xxx/.config/coc/extensions/coc-go-data/tools go get -d -u golang.org/x/tools/cmd/gopls

fish: Unsupported use of '='. To run 'go' with a modified environment, please use 'env GOPATH=/Users/xxx/.config/coc/extensions/coc-go-data/tools go…'
GOPATH=/Users/xxx/.config/coc/extensions/coc-go-data/tools go get -d -u github.com/fatih/gomodifytags

The error explains the fix, which sets $GOPATH using env instead of using the shell to do so.

@josa42 josa42 merged commit 6c9178d into josa42:master Aug 23, 2019
@setkeh setkeh mentioned this pull request Oct 21, 2020
Closed
setkeh added a commit to setkeh/coc-go that referenced this pull request Oct 25, 2020
@setkeh
Adding the change made in josa42/pull/33 back into code as a fix for …
d467dd6 
…Fish Shell
@setkeh setkeh mentioned this pull request Oct 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oncomouse @josa42