disable log.showSignature config for git commands by default #561
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Local test run results |
gitlint doesnt work properly if the global configuration of the users enables log.showSignature config. See below as an example: ``` git log commit 4d91197 (HEAD -> main, upstream/main, upstream/HEAD) gpg: Signature made Sat 02 Sep 2023 08:25:48 AM UTC gpg: using RSA key 4AEE18F83AFDEB23 gpg: Can't check signature: No public key Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat Sep 2 10:25:48 2023 +0200 Bump python from 3.11.4-alpine to 3.11.5-alpine (jorisroovers#525) Bumps python from 3.11.4-alpine to 3.11.5-alpine. --- updated-dependencies: gitlint An error occurred while executing 'git log gpg: Signature made Sat 02 Sep 2023 08:25:48 AM UTCgpg: using RSA key 4AEE18F83AFDEB23gpg: Can't check signature: No public key4d9119760056492eabc201bfad5de2f9e660b85f -1 --pretty=%aN%x00%aE%x00%ai%x00%P%n%B': b"fatal: invalid object name 'gpg'." ``` After disabling log.showSignature config for git runs made by gitlint, it works as expected. ``` hatch run dev:gitlint An error occurred while executing 'git log gpg: Signature made Sat 02 Sep 2023 08:25:48 AM UTCgpg: using RSA key 4AEE18F83AFDEB23gpg: Can't check signature: No public key4d9119760056492eabc201bfad5de2f9e660b85f -1 --pretty=%aN%x00%aE%x00%ai%x00%P%n%B': b"fatal: invalid object name 'gpg'." ^^ this is before fix in dev environment hatch run dev:gitlint ^^ this is after fix as expected ```
|
fix linting issues |
|
I have |
|
See integration test run results (locally): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gitlint doesnt work properly if the configuration of the users enables log.showSignature config. See below as an example:
After disabling log.showSignature config for git runs made by gitlint, it works as expected.
Enter your PR details here