Merge pull request #10 from konart/add-golangci-lint

[WIP]:Add golangci lint

.golangci.yml

@@ -0,0 +1,80 @@
+linters-settings:
+  dupl:
+    threshold: 100
+  funlen:
+    lines: 100
+    statements: 50
+  gci:
+    sections:
+      - standard
+      - default
+  goconst:
+    min-len: 2
+    min-occurrences: 2
+  gocritic:
+    enabled-tags:
+      - diagnostic
+      - opinionated
+      - performance
+      - style
+    disabled-checks:
+      - dupImport # https://github.com/go-critic/go-critic/issues/845
+      - commentedOutCode
+  gocyclo:
+    min-complexity: 15
+  gomnd:
+    settings:
+      mnd:
+        # don't include the "operation" and "assign"
+        checks: 
+          - argument
+          - case
+          - condition 
+          - return
+  govet:
+    check-shadowing: true
+  lll:
+    line-length: 140
+  nolintlint:
+    allow-leading-space: true # don't require machine-readable nolint directives (i.e. with no leading space)
+    allow-unused: false # report any unused nolint directives
+    # require-explanation: false # don't require an explanation for nolint directives
+    require-specific: false # don't require nolint directives to be specific about which linter is being skipped
+
+linters:
+  # please, do not use `enable-all`: it's deprecated and will be removed soon.
+  # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
+  disable-all: true
+  enable:
+    - gci
+    - bodyclose
+    - dogsled
+    - dupl
+    - errcheck
+    - exhaustive
+    - funlen
+    - gochecknoinits
+    - goconst
+    - gocritic
+    - gocyclo
+    - gofmt
+    - gomnd
+    - goprintffuncname
+    - gosec
+    - gosimple
+    - govet
+    - ineffassign
+    - lll
+    - nakedret
+    - noctx
+    - nolintlint
+    - rowserrcheck
+    - exportloopref
+    - staticcheck
+    - revive
+    - typecheck
+    - unconvert
+    - unparam
+    - unused
+    - whitespace
+    - wsl

components/ConnectionForm.go → components/connectionForm.go

@@ -144,7 +144,7 @@ func (form *ConnectionForm) inputCapture(connectionPages *models.ConnectionPages
 func (form *ConnectionForm) testConnection(connectionString string) {
 	form.StatusText.SetText("Connecting...").SetTextStyle(tcell.StyleDefault.Foreground(tcell.ColorKhaki.TrueColor()))
 
-	db := drivers.MySql{}
+	db := drivers.MySQL{}
 	db.SetConnectionString(connectionString)
 
 	err := db.TestConnection()

components/ConnectionSelection.go → components/connectionSelection.go

@@ -133,7 +133,7 @@ func (cs *ConnectionSelection) connect(connectionUrl string) {
 		cs.StatusText.SetText("Connecting...").SetTextStyle(tcell.StyleDefault.Foreground(app.ActiveTextColor))
 		App.Draw()
 
-		newDbDriver := drivers.MySql{}
+		newDbDriver := drivers.MySQL{}
 		newDbDriver.SetConnectionString(connectionUrl)
 
 		err := newDbDriver.Connect()

components/Home.go → components/home.go

@@ -16,13 +16,13 @@ type Home struct {
 	TabbedPane      *TabbedPane
 	LeftWrapper     *tview.Flex
 	RightWrapper    *tview.Flex
-	DBDriver        drivers.MySql
+	DBDriver        drivers.MySQL
 	FocusedWrapper  string
 	ListOfDbChanges []models.DbDmlChange
 	ListOfDbInserts []models.DbInsert
 }
 
-func NewHomePage(name string, dbdriver drivers.MySql) *Home {
+func NewHomePage(name string, dbdriver drivers.MySQL) *Home {
 	tree := NewTree(&dbdriver)
 	tabbedPane := NewTabbedPane()
 	leftWrapper := tview.NewFlex()

components/ResultsTable.go → components/resultsTable.go

@@ -45,7 +45,7 @@ type ResultsTable struct {
 	EditorPages *tview.Pages
 	ResultsInfo *tview.TextView
 	Tree        *Tree
-	DBDriver    *drivers.MySql
+	DBDriver    *drivers.MySQL
 }
 
 var (
@@ -55,7 +55,7 @@ var (
 	DeleteColor = tcell.ColorRed
 )
 
-func NewResultsTable(listOfDbChanges *[]models.DbDmlChange, listOfDbInserts *[]models.DbInsert, tree *Tree, dbdriver *drivers.MySql) *ResultsTable {
+func NewResultsTable(listOfDbChanges *[]models.DbDmlChange, listOfDbInserts *[]models.DbInsert, tree *Tree, dbdriver *drivers.MySQL) *ResultsTable {
 	state := &ResultsTableState{
 		records:         [][]string{},
 		columns:         [][]string{},
@@ -201,7 +201,7 @@ func (table *ResultsTable) AddInsertedRows() {
 		for j, cell := range row {
 			tableCell := tview.NewTableCell(cell)
 			tableCell.SetExpansion(1)
-			tableCell.SetReference(inserts[i].RowId)
+			tableCell.SetReference(inserts[i].RowID)
 
 			tableCell.SetTextColor(app.FocusTextColor)
 			tableCell.SetBackgroundColor(InsertColor)
@@ -397,7 +397,7 @@ func (table *ResultsTable) tableInputCapture(event *tcell.EventKey) *tcell.Event
 			for i, insertedRow := range *table.state.listOfDbInserts {
 				cellReference := table.GetCell(selectedRowIndex, 0).GetReference()
 
-				if cellReference != nil && insertedRow.RowId.String() == cellReference.(uuid.UUID).String() {
+				if cellReference != nil && insertedRow.RowID.String() == cellReference.(uuid.UUID).String() {
 					isAnInsertedRow = true
 					indexOfInsertedRow = i
 				}
@@ -447,7 +447,7 @@ func (table *ResultsTable) tableInputCapture(event *tcell.EventKey) *tcell.Event
 				Table:   table.GetDBReference(),
 				Columns: table.GetRecords()[0],
 				Values:  newRow,
-				RowId:   newRowUuid,
+				RowID:   newRowUuid,
 				Option:  1,
 			}
 
@@ -958,19 +958,19 @@ func (table *ResultsTable) StartEditingCell(row int, col int, callback func(newV
 	App.SetFocus(inputField)
 }
 
-func (table *ResultsTable) CheckIfRowIsInserted(rowId uuid.UUID) bool {
+func (table *ResultsTable) CheckIfRowIsInserted(rowID uuid.UUID) bool {
 	for _, insertedRow := range *table.state.listOfDbInserts {
-		if insertedRow.RowId == rowId {
+		if insertedRow.RowID == rowID {
 			return true
 		}
 	}
 
 	return false
 }
 
-func (table *ResultsTable) MutateInsertedRowCell(rowId uuid.UUID, colIndex int, newValue string) {
+func (table *ResultsTable) MutateInsertedRowCell(rowID uuid.UUID, colIndex int, newValue string) {
 	for i, insertedRow := range *table.state.listOfDbInserts {
-		if insertedRow.RowId == rowId {
+		if insertedRow.RowID == rowID {
 			(*table.state.listOfDbInserts)[i].Values[colIndex] = newValue
 		}
 	}
@@ -992,13 +992,13 @@ func (table *ResultsTable) AppendNewChange(changeType string, tableName string,
 	}
 
 	if !isInsertedRow {
-		selectedRowId := table.GetRecords()[rowIndex][0]
+		selectedRowID := table.GetRecords()[rowIndex][0]
 
 		alreadyExists := false
 		indexOfChange := -1
 
 		for i, change := range *table.state.listOfDbChanges {
-			if change.RowId == selectedRowId && change.Column == table.GetColumnNameByIndex(colIndex) {
+			if change.RowID == selectedRowID && change.Column == table.GetColumnNameByIndex(colIndex) {
 				alreadyExists = true
 				indexOfChange = i
 			}
@@ -1038,7 +1038,7 @@ func (table *ResultsTable) AppendNewChange(changeType string, tableName string,
 					Table:  tableName,
 					Column: columnName,
 					Value:  value,
-					RowId:  selectedRowId,
+					RowID:  selectedRowID,
 					Option: 1,
 				}
 
@@ -1078,7 +1078,7 @@ func (table *ResultsTable) AppendNewChange(changeType string, tableName string,
 					Table:  tableName,
 					Column: "",
 					Value:  "",
-					RowId:  selectedRowId,
+					RowID:  selectedRowID,
 					Option: 1,
 				}
 

components/Tree.go → components/tree.go

@@ -19,11 +19,11 @@ type TreeState struct {
 type Tree struct {
 	*tview.TreeView
 	state       *TreeState
-	DBDriver    *drivers.MySql
+	DBDriver    *drivers.MySQL
 	subscribers []chan models.StateChange
 }
 
-func NewTree(dbdriver *drivers.MySql) *Tree {
+func NewTree(dbdriver *drivers.MySQL) *Tree {
 	state := &TreeState{
 		selectedDatabase: "",
 		selectedTable:    "",