This repository was archived by the owner on Feb 18, 2024. It is now read-only.
Improved performance of primitive comparisons.#16
Merged
jorgecarleitao merged 1 commit intomainfrom Mar 21, 2021
Merged
Conversation
Implementation based on [this comment](apache/arrow#9759 (comment)) from @yordan-pavlov. Performance: eq Float32 time: [70.990 us 71.775 us 72.636 us] change: [-12.665% -10.799% -8.9867%] (p = 0.00 < 0.05) Performance has improved. Found 4 outliers among 100 measurements (4.00%) 3 (3.00%) high mild 1 (1.00%) high severe eq scalar Float32 time: [26.832 us 27.174 us 27.540 us] change: [-52.665% -51.655% -50.525%] (p = 0.00 < 0.05) Performance has improved.
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 63.23% 63.31% +0.08%
==========================================
Files 150 150
Lines 14391 14424 +33
==========================================
+ Hits 9100 9133 +33
Misses 5291 5291
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation based on this comment from @yordan-pavlov.
Performance: