Falsey attributes

jorgebucaran · Mar 29, 2018 · c0f3013 · c0f3013
1 parent 538a93e
commit c0f3013
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -178,7 +178,12 @@ export function app(state, actions, view, container) {
         } else {
           element.removeEventListener(name, eventListener)
         }
-      } else if (name in element && name !== "list" && !isSvg) {
+      } else if (
+        name in element &&
+        name !== "list" &&
+        typeof element[name] !== "boolean" &&
+        !isSvg
+      ) {
         element[name] = value == null ? "" : value
       } else if (value != null && value !== false) {
         element.setAttribute(name, value)

diff --git a/test/dom.test.js b/test/dom.test.js
@@ -652,3 +652,10 @@ testVdomToHtml("events", [
     html: `<button id="clicked"></button>`
   }
 ])
+
+testVdomToHtml("boolean attributes", [
+  {
+    vdom: <input spellcheck="false" autocomplete="off" translate="no" />,
+    html: `<input spellcheck="false" autocomplete="off" translate="no">`
+  }
+])