-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: better dirty state #54
Open
zzhaolei
wants to merge
1
commit into
jorgebucaran:main
Choose a base branch
from
zzhaolei:better-dirty-state
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jorgebucaran Please review this PR |
This is probably good. I also had a couple of weird issues with the dirty status. Thank you! I just need to test it on the wild for a while before we're able to merge. |
Hello, I have been using it for three weeks and haven't noticed any problems. Can it be merged? |
Good to know, thanks! |
auscompgeek
reviewed
May 14, 2024
zzhaolei
force-pushed
the
better-dirty-state
branch
from
May 16, 2024 04:22
11d741d
to
1197189
Compare
Old``` count (git status --porcelain=v2 --untracked-files=no) >/dev/null; or count (command git ls-files --others --exclude-standard) >/dev/null; and set info \"$hydro_symbol_git_dirty\" ```Edited:
# Incorrect outputs
❯ time command git ls-files --others --exclude-standard [17:37:03]
________________________________________________________
Executed in 28.84 millis fish external
usr time 16.23 millis 0.09 millis 16.14 millis
sys time 10.42 millis 1.08 millis 9.33 millis
# Correct outputs
❯ time command git ls-files --others --exclude-standard .. [17:37:05]
../1
________________________________________________________
Executed in 941.38 millis fish external
usr time 202.08 millis 0.11 millis 201.97 millis
sys time 777.69 millis 1.10 millis 776.59 millis
# Correct outputs
❯ time command git ls-files --others --exclude-standard $(command git rev-parse --show-toplevel) [17:37:10]
../1
________________________________________________________
Executed in 930.11 millis fish external
usr time 198.21 millis 0.12 millis 198.09 millis
sys time 769.98 millis 1.20 millis 768.78 millis
~/R/nixpkgs/lib master• > |
zzhaolei
force-pushed
the
better-dirty-state
branch
from
May 17, 2024 09:29
1197189
to
1170524
Compare
zzhaolei
force-pushed
the
better-dirty-state
branch
from
May 17, 2024 09:32
1170524
to
65f1302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current dirty status may be incorrect, use better detection method
Incorrect, Nothing actually changes:
Correct:
Performance:
No performance regression.
(Can it be tested like this?🤔)