Skip to content
This repository has been archived by the owner on Jun 16, 2024. It is now read-only.

Add WinQuoteRequest #510

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BenjaminP-GitHub
Copy link

@BenjaminP-GitHub BenjaminP-GitHub commented Jun 17, 2020

Added support for the WinQuoteRequest SDK Message. Implemented to mirror the already implemented CloseQuoteRequestExecutor.

Questions:

  • Should the update of the statecode to Won also be implemented in the executor? Currently similar executors do not, so I have omitted it.
  • Should the creation of the QuoteClose record also be implemented in the executor? Similar ones do not currently.

@BenjaminP-GitHub BenjaminP-GitHub changed the title Add WinQuoteRequest message support and tests Add WinQuoteRequest Jun 17, 2020
@jordimontana82 jordimontana82 added this to the v2.x milestone Jun 18, 2020
@jordimontana82
Copy link
Owner

Thanks @BenjaminP-GitHub

Yeah, if these messages update the statecode then I think other fake message executors should also implement it to be consistent with the state of a real CDS / CRM environment after executing these.

So Yes to both questions in my opinion, and so existing executors might need to be revisited so.

…ty; update CloseQuoteRequest to be consistent
@BenjaminP-GitHub
Copy link
Author

BenjaminP-GitHub commented Jul 18, 2020

@jordimontana82 I've implemented the Quote statecode update and the QuoteClose activity creation for both WinQuoteRequest and CloseQuoteRequest

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants