-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpine Package Keeper (apk) format support #1054
Conversation
… output concatted tar is also gzipped
…irectories or nul records
…ually- zipped before concatenation.
… written to the resultant tar.
…oved from control tar
…ksum linkname stuff
I haven't read the code yet, nor tested, but let me respond to your concerns first --
I am OK with this. While having tests would be lovely, it is OK if you aren't sure how to write them! We can work on this iteratively. I suspect some folks manually testing this would be enough for me to be happy merging. I will try to test it myself also. :)
Not required. What you have (making a package) is great! We can always add "from APK" support in the future.
I have no policy. 30 commits is fine with me :) |
Any chance we can move this forward? Can't wait to use it to create the official Kong Docker packages. |
@thefosk I'd love to! I currently have a plethora of windows boxes, none of which can run Alpine linux due to a bug somewhere between Hyper-V and Alpine Linux (the boot from the 3.3.1 and 3.3.3 ISO both hang similar to reported here). As I can't test this right now, I'd love feedback from Alpine users who can help this PR get some feedback on usage, bugs, etc. |
+1, testing it. |
+1 |
Tested using the alpine docker image:
Looks like it worked! I'm not sure what to test beyond this, but functionally it seems good (given my zero experience level with Alpine) |
Great news, thank you! |
Awesome! That's pretty similar to my tests, I tested a few init scripts and binaries together. I never observed that error @jordansissel Also just to put it out there, if you'd like I'm willing to field bugs and questions people may have on the APK support. But I don't really watch the |
@Knetic thank you much for the offer to help support folks as they play with the new apk support. Will ping you as appropriate via email ❤️ |
Alpine Package Keeper (apk) format support
any news ? |
@freeseacher about what? This was merged 5 months ago. |
ou, sorry, i just read doc and did not find it. so i search for pull request and found that one. |
I confirm that docs are not updated. |
Thanks a lot @Knetic, Now,
I would very much like to know how the above can be achieved, i.e., adding preinstall, postupgrade control scripts and dependencies when doing the https://salsa.debian.org/debian/dbab Thanks! |
OMG, it is much simpler than I thought --
So what's only remains is how to add preinstall, postupgrade control scripts. |
Hey @suntong , the control scripts and dependencies are specified like this;
(taken from the wiki which lists out the usage of fpm). |
Thanks @Knetic, I was at the wiki, but didn't see |
Hi @Knetic, would it be possible for command line I tried but am still getting:
and when I tried to install it, I got:
Thanks for your consideration. |
After making #1042, I decided to give it a crack. This PR adds an "apk" destination which works just like you'd expect; implementing Alpine Linux packages.
Just to list it out so it's easy to see, this PR supports the following things beside the usual "install files to the right places";
A few things to note (so you don't have to pick through the code to notice it);