Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming attachments instead of their fetching into buffers #157

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

YuriiRubakha
Copy link

In some use cases attachment data is streamed from external source. Fetching this data into buffers causes additional memory consumption, which may be significant for massive emails sending.
To solve this we propose to stream attachments data directly from readers, as they provided by external interface of package (no external interface change).

Internal structures changed accordingly. Some tests changed also to match the new Attachment struct.

No significant negative impact on performance.

YuriiRubakha and others added 9 commits July 18, 2023 18:40

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Francisco Delmar Kurpiel <francisco.kurpiel@simplesurance.de>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Fabian Holler <mail@fholler.de>
…-new' into CORE-10934-attachments-streaming-new

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ming-new

[CORE-10934]-Redusing-memory-attachments-streaming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant