[4.0] Make it possible for 3.10 to find the 4.0.0-dev updates#145
[4.0] Make it possible for 3.10 to find the 4.0.0-dev updates#145wilsonge merged 3 commits intojoomla:masterfrom zero-24:310to40
Conversation
|
That is not what I reported. |
|
I'm sorry, you pointed me to this issue so I want to credit you sorry for tagging you here. |
|
Maybe I am wrong but when I tested the pre-update checker I was doing it as per the instructions with local xml files and it didnt work - so its not the same issue? |
|
The instruction in that original issue point to an 3.9 update server. As you are running 3.10 than this fails also with the local update server. With this patch here the pre update checker pops up for me: Feel free to check it yourself by using this patched version of the update server: https://www.jah-tz.de/downloads/core/nightlies/next_major_list.xml |
|
You don’t need another updateserver definition. Adjust the regex to allow
3.9 and 3.10 and you’re all set.
On Thu, Aug 29, 2019 at 5:23 PM zero-24 ***@***.***> wrote:
Make sure 3.10 can find the update to 4.0-dev cc @HLeithner
<https://github.com/HLeithner> @wilsonge <https://github.com/wilsonge>
As reported by @brianteeman <https://github.com/brianteeman> here:
joomla/joomla-cms#26048
<joomla/joomla-cms#26048>
------------------------------
You can view, comment on, or merge this pull request online at:
#145
Commit Summary
- make it possible for 3.10 to find the 4.0.0-dev updates
File Changes
- *M* www/core/nightlies/next_major_extension.xml
<https://github.com/joomla/update.joomla.org/pull/145/files#diff-0>
(19)
Patch Links:
- https://github.com/joomla/update.joomla.org/pull/145.patch
- https://github.com/joomla/update.joomla.org/pull/145.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#145?email_source=notifications&email_token=AACZ7ILDPDTBMGQLCLAJNCTQHBD53A5CNFSM4ISHLUNKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIKDVEA>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACZ7IMGLSCE3JES7REU6GTQHBD53ANCNFSM4ISHLUNA>
.
--
- Michael Please pardon any errors, this message was sent from my iPhone.
|
|
I'm not a master with regex but as far as i know the only possibility would be "3.*" that would allow all 3.x sites to see that update. IIRC there was a problem to handle 3.9 with just one digit after the dot and 3.10 with two digits after the dot. In the end we only want to allow updates from 3.10 anyway so I have just updated the patch to reflect that. |
On a first look this seams to be good to go just make sure you don't actually update to that version as this is local server points to an outdated version ;) Can you show me the message that comes up when you use your local server and what happen when you use the patched update server (https://www.jah-tz.de/downloads/core/nightlies/next_major_list.xml) as mention above? I'm sure you have already hit refresh updates etc after the latest changes to that file right? And what is your running php version and mysql version? |
|
Ah seams to be fixed now, so this patch here is ready to go. Thanks for your feedback :) |
|
Check the install from web or patch tester XML’s, it’s actually really
simple (I’m saying that as someone who speaks better German than regex 😉)
On Thu, Aug 29, 2019 at 5:42 PM zero-24 ***@***.***> wrote:
I'm not a master with regex but as far as i know the only possibility
would be "3.*" that would allow all 3.x sites to see that update. IIRC
there was a problem to handle 3.9 with just one digit after the dot and
3.10 with two digits after the dot.
In the end we only want to allow updates from 3.10 anyway so I have just
updated the patch to reflect that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#145?email_source=notifications&email_token=AACZ7III2KEHTD64GFYIR3LQHBGFDA5CNFSM4ISHLUNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QA4CQ#issuecomment-526388746>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACZ7IJ6WIQOJY3GFW3LG5TQHBGFDANCNFSM4ISHLUNA>
.
--
- Michael Please pardon any errors, this message was sent from my iPhone.
|
|
Ah it would be |
|
Continue allowing 3.9 for now (it will be 3.10 only but right now I haven't merged all the conflicts from the 3.10 branch into the 4.0-dev branch). Once conflicts are resolved then 3.10 only |
|
10.1 Minimum for MariaDB //cc @HLeithner (what you proposed in the Production glip) |
|
@wilsonge @HLeithner the required changes have been made. I'm making a new PR for the mariadb thing :) |
|
MariaDB PR is: #146 |
|
@wilsonge @HLeithner friendly reminder for this PR to be merged thanks. |
|
Thanks @wilsonge 👍 |



Make sure 3.10 can find the update to 4.0-dev cc @HLeithner @wilsonge
As reported by @brianteeman here: joomla/joomla-cms#26048