Skip to content

[4.0] Make it possible for 3.10 to find the 4.0.0-dev updates#145

Merged
wilsonge merged 3 commits intojoomla:masterfrom
zero-24:310to40
Oct 31, 2019
Merged

[4.0] Make it possible for 3.10 to find the 4.0.0-dev updates#145
wilsonge merged 3 commits intojoomla:masterfrom
zero-24:310to40

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Aug 29, 2019

Make sure 3.10 can find the update to 4.0-dev cc @HLeithner @wilsonge

As reported by @brianteeman here: joomla/joomla-cms#26048

@brianteeman
Copy link
Contributor

That is not what I reported.

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 29, 2019

I'm sorry, you pointed me to this issue so I want to credit you sorry for tagging you here.

@brianteeman
Copy link
Contributor

Maybe I am wrong but when I tested the pre-update checker I was doing it as per the instructions with local xml files and it didnt work - so its not the same issue?

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 29, 2019

The instruction in that original issue point to an 3.9 update server. As you are running 3.10 than this fails also with the local update server.

With this patch here the pre update checker pops up for me:
image

Feel free to check it yourself by using this patched version of the update server: https://www.jah-tz.de/downloads/core/nightlies/next_major_list.xml

@mbabker
Copy link
Contributor

mbabker commented Aug 29, 2019 via email

@brianteeman
Copy link
Contributor

Maybe I did it wrong but I did change the xml

image

image

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 29, 2019

I'm not a master with regex but as far as i know the only possibility would be "3.*" that would allow all 3.x sites to see that update. IIRC there was a problem to handle 3.9 with just one digit after the dot and 3.10 with two digits after the dot.

In the end we only want to allow updates from 3.10 anyway so I have just updated the patch to reflect that.

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 29, 2019

Maybe I did it wrong but I did change the xml

On a first look this seams to be good to go just make sure you don't actually update to that version as this is local server points to an outdated version ;)

Can you show me the message that comes up when you use your local server and what happen when you use the patched update server (https://www.jah-tz.de/downloads/core/nightlies/next_major_list.xml) as mention above? I'm sure you have already hit refresh updates etc after the latest changes to that file right?

And what is your running php version and mysql version?

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 29, 2019

Ah seams to be fixed now, so this patch here is ready to go. Thanks for your feedback :)

@mbabker
Copy link
Contributor

mbabker commented Aug 29, 2019 via email

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 29, 2019

Ah it would be 3.(9|10) than :) Learned something new today thanks :)

@wilsonge
Copy link
Contributor

Continue allowing 3.9 for now (it will be 3.10 only but right now I haven't merged all the conflicts from the 3.10 branch into the 4.0-dev branch). Once conflicts are resolved then 3.10 only

@wilsonge
Copy link
Contributor

10.1 Minimum for MariaDB //cc @HLeithner (what you proposed in the Production glip)

@zero-24
Copy link
Contributor Author

zero-24 commented Sep 13, 2019

@wilsonge @HLeithner the required changes have been made. I'm making a new PR for the mariadb thing :)

@zero-24
Copy link
Contributor Author

zero-24 commented Sep 13, 2019

MariaDB PR is: #146

@zero-24
Copy link
Contributor Author

zero-24 commented Oct 26, 2019

@wilsonge @HLeithner friendly reminder for this PR to be merged thanks.

@wilsonge wilsonge merged commit 7b523cc into joomla:master Oct 31, 2019
@zero-24 zero-24 deleted the 310to40 branch October 31, 2019 11:40
@zero-24
Copy link
Contributor Author

zero-24 commented Oct 31, 2019

Thanks @wilsonge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants