Backport FW filter package changes: allow arrays process by clean()

[photodude]

Updates the CMS Framework package to framework/filter 1.2.0 with Composer

Backports Framework changes: Allow arrays of numbers to be processed by clean() and associated tests.
joomla-framework/filter#13
Backports additional changes from framework/filter 1.2.0

• Add array support to most filters
  • Fixes Array to String conversion notices in clean() for most cases
• Updates pcre patterns for numbers
  • Fixes floats case to properly handle exponent type floats rather than just decimal floats
• Adds new general cases to test and verify the array filter functionality
• Code style: fixes missing comma at end of array lists.
  *Fixes PHP7 issues

Testing
https://docs.joomla.org/Testing_Joomla!_patches
Do a general check that the various existing forms in the CMS function as expected.

[photodude]

@mbabker Here is the backport of the recent framework changes for the input filter clean() method and test.

[photodude]

@RickR2H would you be willing to test this?

[RickR2H]

@photodude I'll test this if I can. What is the best procedure to test as I don't have in depth knowledge of the code as I'm only a frontend developer ;)

[photodude]

I would just do a general check that the various existing forms in the CMS function as expected.
I'm not sure there are any easy tests beyond that which could have a "clean" method triggered for testing.

[photodude]

@mbabker @wilsonge Updated to match changes in framework/filter 1.2.0

[photodude]

@brianteeman Unlike @wilsonge 's PR #8734 for updating to the current the framework package. This filter class is used in the CMS core.
This should have consideration for merging for 3.5

[brianteeman]

Not sure why that comment is addressed at me. I have no say on what gets merged or when

[photodude]

I only Pinged you since You had asked in #8734 if that PR "need to be merged before 3.5"

[wilsonge]

Merge this: photodude#1

Get some testers in here. I've gotta focus on the sql upgrade. But added a 3.5 blocker tag as even though the FW filter package isn't being used by core - let's not run into PHP 7 issues because 3rd parties are using the framework filter package :)

[photodude]

@RickR2H would you still be willing to test this?

[Stevec4]

I received an error after applying this patch.
Fatal error: Uncaught Error: Class 'ComposerAutoloaderInit205c915b9c7d3e718e7c95793ee67ffe' not found in C:\xampp\htdocs\sites\aviondemo\libraries\vendor\autoload.php:7 Stack trace: #0 C:\xampp\htdocs\sites\aviondemo\libraries\cms.php(33): require() #1 C:\xampp\htdocs\sites\aviondemo\administrator\includes\framework.php(23): require_once('C:\\xampp\\htdocs...') #2 C:\xampp\htdocs\sites\aviondemo\administrator\index.php(40): require_once('C:\\xampp\\htdocs...') #3 {main} thrown in C:\xampp\htdocs\sites\aviondemo\libraries\vendor\autoload.php on line 7
I applied the patch to a 3.5 beta site running php 7.0.2
Let me know if I can provide any more info.
Steve

[photodude]

@Stevec4 Thanks for testing, I didn't create the part of this PR for the composer changes So I'll have to dig into what's going on.

I'm not sure, but I think this patch might need to be applied against Stagging, before the composer changes were added it would have been a test against 3.4.8 or possibly 3.5B2.
The composer changes and the PHP7 compatibility add some different dynamics.

I'll see if I can rebase this soon since there are some new merge conflicts.

[photodude]

@Stevec4 I've rebased to staging and fixed the Merge conflicts. I think the issue you reported should be fixed. I tested against Staging, So I'm not sure about success for testing from J3.5B2 and then applying the patch.

[Stevec4]

@photodude I have re applied the patch to both a 348 install and a 3.50b2 install with no issues.
I checked several forms and they seem to function correctly.
Steve

[anibalsanchez]

I have tested this item ✅ successfully on 23ca41a

Test OK

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8681.}

[photodude]

@Stevec4 thanks for the test. Would you please go to the issue tracker and mark it as a successful test.
https://issues.joomla.org/tracker/joomla-cms/8681

[brianteeman]

Manually added the test from @Stevec4

Marking RTC - thanks everyone

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8681.}

[wilsonge]

Merged -thanks all!

[photodude]

Thanks Everyone. I appreciate all the work and testing.

[beat]

Why did a comma got added here and just below ?

[wilsonge]

I personally prefer it when you have multiple array elements. I don't think our code style policy defines either way...

[photodude]

It's a Joomla Coding styles option.
"When splitting array definitions onto several lines, the last value may also have a trailing comma."
I follow that the last value should have a trailing comma