Closed
Conversation
added 4 commits
August 5, 2015 09:05
No need for a hackish workaround for an unused table column.
Member
|
PR works as intended. Able to create and edit tags. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7628. |
Contributor
|
Tested successful. What was changed that produces this issue? I have just see a component that has similiar issues on staging but no issues on 3.4.3 which is a B/C break ;) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7628. |
Member
|
Thank you @Bakual! Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The tag edit view currently shows the "images" tab twice.
This PR
While trying to fix the doubled tab, I suprisingly stumbled over a few other funny things in that form. So I fixed those as well. This PR now
JHtml::addIncludePath()call since the added path doesn't even exist.$params"shortcut". We're not using params anywhere in the layout.Testing
Make sure you can create and edit tags.