Skip to content

Tag edit form cleanup#7628

Closed
Bakual wants to merge 4 commits intojoomla:stagingfrom
Bakual:TagURL
Closed

Tag edit form cleanup#7628
Bakual wants to merge 4 commits intojoomla:stagingfrom
Bakual:TagURL

Conversation

@Bakual
Copy link
Copy Markdown
Contributor

@Bakual Bakual commented Aug 5, 2015

Issue

The tag edit view currently shows the "images" tab twice.

This PR

While trying to fix the doubled tab, I suprisingly stumbled over a few other funny things in that form. So I fixed those as well. This PR now

  • Removes the doubled "images" tab, leaving it to the JLayout to render it.
  • Removes a workaround for the "urls" columng in the #__tags table. The underlying issue has been fixed with PostgreSQL - SQL error when add new tag #6314. The column isn't used anywhere and could most likely be removed from the database. I just leave it there for B/C reasons.
  • Removes a JHtml::addIncludePath() call since the added path doesn't even exist.
  • Removes $params "shortcut". We're not using params anywhere in the layout.

Testing

Make sure you can create and edit tags.

@jwaisner
Copy link
Copy Markdown
Member

jwaisner commented Aug 6, 2015

@test

PR works as intended. Able to create and edit tags.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7628.

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Aug 6, 2015

Tested successful. What was changed that produces this issue? I have just see a component that has similiar issues on staging but no issues on 3.4.3 which is a B/C break ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7628.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 6, 2015
@Kubik-Rubik
Copy link
Copy Markdown
Member

Thank you @Bakual! Merged.

@Kubik-Rubik Kubik-Rubik added this to the Joomla! 3.4.4 milestone Aug 6, 2015
@Bakual Bakual closed this in 7c62d8d Aug 6, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 6, 2015
@Bakual Bakual deleted the TagURL branch August 6, 2015 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants