MSSQL - fix typo error on getTableColumns()#7426
Merged
Bakual merged 1 commit intojoomla:stagingfrom Jul 13, 2015
alikon:patch-34
Merged
MSSQL - fix typo error on getTableColumns()#7426Bakual merged 1 commit intojoomla:stagingfrom alikon:patch-34
Bakual merged 1 commit intojoomla:stagingfrom
alikon:patch-34
Conversation
#### Steps to reproduce the issue install current staging on MSSQL #### Expected result The installation goes well #### Actual result the installation process don't end #### System information (as much as possible) Windows 2008 R2 10.50.4033 Apache 2.4.7 PHP 5.5.9 Joomla! 3.4.4-dev #### Additional comments this error was introduced by this commit 2f76e54 #6314 there was a typo on function getTableColumns() accordingly to query ``` 'SELECT column_name as Field, data_type as Type, is_nullable as \'Null\', column_default as \'Default\'' . ' FROM information_schema.columns WHERE table_name = ' . $this->quote($table_temp) ``` should be ```$field->Type``` instead of ```$field->type``` sorry for this 😇
Bakual
pushed a commit
that referenced
this pull request
Jul 13, 2015
MSSQL - fix typo error on getTableColumns()
Contributor
|
Merged based on review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue
install current staging on MSSQL
Expected result
The installation goes well
Actual result
the installation process don't end
System information
Windows 2008 R2 10.50.4033
Apache 2.4.7
PHP 5.5.9
Joomla! 3.4.4-dev
Additional comments
this error was introduced by this commit 2f76e54 #6314
there was a typo on function getTableColumns()
accordingly to query
should be
$field->Typeinstead of$field->typesorry for this 😇