new feature: plugin modal view needed for quicker edit

[shamsbd71]

in admin just the way joomla has module modal edit view, we need to have plugin edit view in modal to save its settings. we dont want to forward users to find and edit things

Test Instructions:

i have showed in com_redirect with full functional language, helper and view files. so if you visit com_redirect
administrator/index.php?option=com_redirect
you will see how its working.

thanks

[n9iels]

Can you please give some test instructions? And also tell us what and where you exactly add new features?

[shamsbd71]

hi @n9iels
i'm building a Joomla! eCommerce extension for digital goods, its been called as "Digicom". feel free to check at https://github.com/themexpert/digicom

we have plugins for payment and some other operations. and users need to fill the info by themselves.
but to do that they need to do many clicks, search , edit , save and then come back to the extension
:(
so to avoid this situation we want to give them links at sidebar (that we have created) and users will click on it, it opens, they save and its gone :)

i'm attaching some screen capture, hope it will help
thanks

[shamsbd71]

One more thing, please check this file
https://github.com/themexpert/digicom/blob/develop/plugins/digicom_pay/paypal/paypal.php
you will see a method name : onSidebarMenuItem
this is the event i have created for #digicom to show the links from plugin

** joomla already have the same feature for modules. and we can live edit the modules from menu item edit view. we need that for module too. :)
let me know if i need to provide something more.

[Fedik]

seems it could be a nice feature in your extension,
but I have doubt where such thing can be useful in Joomla ... I did not understand this part from your explanation

[shamsbd71]

@Fedik
you are right that in general Joomla! doesn't need plugin to edit on the fly like module as plugin has no option to load on specific pages. but
as plugin is obvious and many Joomla! extensions require to get info/settings to be updated by admin.
so if you enable this options as built in, from now many developer will use it to give the Joomla! users a nice n quicker action to edit plugin the way we can do with modules.

and it will improve users experience
thanks

[brianteeman]

I "think" I can see the use case for this directly in the core - if I
understand correctly

For example in com_redirect by default you get a message
The Redirect Plugin is disabled. Enable it in the Plugin Manager.

If I understand you correctly then with this PR that message could be
changed to a modal link to the plugin?

On 25 June 2015 at 09:30, Abu-Huraira [email protected] wrote:

@Fedik https://github.com/Fedik
you are right that in general Joomla! doesn't need plugin to edit on the
fly like module as plugin has no option to load on specific pages. but
as plugin is obvious and many Joomla! extensions require to get
info/settings to be updated by admin.
so if you enable this options as built in, from now many developer will
use it to give the Joomla! users a nice n quicker action to edit plugin the
way we can do with modules.

and it will improve users experience
thanks

—
Reply to this email directly or view it on GitHub
#7259 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

[shamsbd71]

@brianteeman
you are right, it can be changed to modal so users can change it directly from that view without visiting anymore pages.

[codexpert]

+1 @brianteeman also from 'com_finder' we can enable/disable the plugin.

There is many use case actually. Many components depends on lot of plugin, for instance 'Virtuemart, Payplans, Jomsocial' etc. So for every change we need to go to plugin manager > search plugin > open and change settings > back to component again.

[brianteeman]

Can I suggest that you update the pull request to include com_redirect.
Then this can be used as an example AND makes testing easier.

The easier it is to test the more likely it is to be reviewed
On 25 Jun 2015 10:35, "Parvez Akther" [email protected] wrote:

+1 @brianteeman https://github.com/brianteeman also from 'com_finder'
we can enable/disable the plugin.

There is many use case actually. Many components depends on lot of plugin,
for instance 'Virtuemart, Payplans, Jomsocial' etc. So for every change we
need to go to plugin manager > search plugin > open and change settings >
back to component again.

—
Reply to this email directly or view it on GitHub
#7259 (comment).

[shamsbd71]

thank you @brianteeman. will do that

[shamsbd71]

I have updated the PR, now it will show in com_redirect in this way :

• test instruction updated in main comment

[brianteeman]

Thanks

On 25 June 2015 at 12:01, Abu-Huraira [email protected] wrote:

I have updated the PR, now it will show in com_redirect in this way :
[image: image]
https://cloud.githubusercontent.com/assets/1936565/8352947/1f004782-1b5b-11e5-8e9b-9c5ce3f7530b.png

• test instruction updated in main comment

—
Reply to this email directly or view it on GitHub
#7259 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

[Bakual]

It may be obvious but I suck at JS. What's the purpose of this?

[shamsbd71]

when we save the plugin it will show the plugin list as its loaded in iframe.
btw, module modal used the same approach and more, i just picked up the code necessary to close modal after it save

[Bakual]

Thanks

[Bakual]

Hmm, can't see that in https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_modules/views/module/tmpl/modal.php. Maybe it got changed recently?

[brianteeman]

Here I think #6804

On 25 June 2015 at 12:55, Thomas Hunziker [email protected] wrote:

In administrator/components/com_plugins/views/plugin/tmpl/edit.php
#7259 (comment):

@@ -20,6 +20,10 @@
{
if (task == 'plugin.cancel' || document.formvalidator.isValid(document.getElementById('style-form'))) {
Joomla.submitform(task, document.getElementById('style-form'));

•       if (self != top){
  

•           window.top.setTimeout('window.parent.jModalClose()', 1000);
  

Hmm, can't see that in
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_modules/views/module/tmpl/modal.php.
Maybe it got changed recently?

—
Reply to this email directly or view it on GitHub
https://github.com/joomla/joomla-cms/pull/7259/files#r33246541.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

[shamsbd71]

sorry i didn't mention the exact file
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_modules/views/module/tmpl/edit.php#L123

but seems its already changed to jquery

[Fedik]

If we want introduce new "popup", it already should be without mootools dependency

[Bakual]

Revert that line to the original. I guess it comes from a bad merge.

[Bakual]

Some things to think about: You create a new method in the RedirectHelper to fetch the ID.
I think that could be something which could be useful for other extensions as well if we introduce this modal. So I guess we could add a getPluginId() method to JPluginHelper instead.
The method also shouldn't use JError (it's deprecated). I'm not even sure if we need to do something with the error or if we just want to return false.

By the way, the RedirectHelper::isEnabled() could probably be replaced with JPluginHelper::isEnabled('system', 'redirect'), but that's another topic.

The modal imho should be wider. Similar to the module modal loaded from the menu item.

Maybe the button also should only be there if we have found a plugin id. Otherwise you get a link to the list.

[Bakual]

administrator/components/com_redirect/views/links/tmpl/default.php has a lot of unrelated changes. You probably had an outdated file there. Make sure you work from current staging code and only change what you want.

[dgrammatiko]

Can we directly introduce a bootstrap modal here? It seems like we stepping backwards introducing a mootools dependency here

[shamsbd71]

@Bakual , @DGT41
thank you, i have implemented the bootstrap way

[roland-d]

@brianteeman Good point, something I was thinking as well after posting my comment. So let's stick to the modals. I do like the original idea.

@shamsbd71 Could you fix the merge conflicts please?

[brianteeman]

@shamsbd71 are you able to resolve the merge conflicts and then we can get this merged

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/7259.}

[ghost]

only PR-dev can resolve merge Conflicts?

[ghost]

who can resolve merge Conflicts?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/7259.}

[brianteeman]

@franz-wohlkoenig anyone with commit access can do it

[ghost]

thanks for Info, @brianteeman is anyone having commit Access willing to resolve merge Conflicts?

[roland-d]

@wilsonge I think it is useful to take this into Joomla 4, what do you think?

[brianteeman]

@wilsonge I think it is useful to take this into Joomla 4, what do you think?

Why wait for J4 - joomla 3 has over 2 years of life

[roland-d]

because there are no new feature releases planned at this moment with exception for 3.8 being the router release.

[brianteeman]

@roland-d where is that documented - its not what the roadmap says https://developer.joomla.org/roadmap.html

[roland-d]

We read the roadmap differently then. It says the following:

The following are the primary features introduced to Joomla! 3.8.

    Modern Routing System
    Joomla! 4 compatibility layer

The features in development are set as the Modern Routing System and General improvements.

[brianteeman]

Well I would say that this is a General improvements. but also keep reading further

Proposed Features

The following are suggested improvements which would be highly favored for this release. If you would like to assist or contribute to them, please contact the release lead or release team for more information.

** To be determined**

[roland-d]

In that case @mbabker do you want this in 3.8? If so we probably need to find someone who wants to clean this up and propose a new PR or for @shamsbd71 to fix this.

[mbabker]

Personally my aim is to keep the major focus on the router. As seen on the project boards, I've flagged a bunch of PRs for 3.8 that are relatively smaller in nature. So honestly, it's going to be a case by case basis right now.

On Sat, May 13, 2017 at 3:51 PM RolandD ***@***.***> wrote: In that case @mbabker <https://github.com/mbabker> do you want this in 3.8? If so we probably need to find someone who wants to clean this up and propose a new PR or for @shamsbd71 <https://github.com/shamsbd71> to fix this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7259 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWfoYZXuNwlJJ5_z5UTy8OnTB2wsID5ks5r5he4gaJpZM4FKrT8> .

-- - Michael Please pardon any errors, this message was sent from my iPhone.

[rdeutz]

So 3.8 or 4.0 @mbabker @wilsonge who will take it :-)

[brianteeman]

3.8 please

…

On 24 May 2017 10:52 a.m., "Robert Deutz" ***@***.***> wrote: So 3.8 or 4.0 @mbabker <https://github.com/mbabker> @wilsonge <https://github.com/wilsonge> who will take it :-) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7259 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABPH8VF09esJ3WFUZm6dFpNO8p_KmHyOks5r8_3UgaJpZM4FKrT8> .

[mbabker]

If this is tested and reviewable I've got no issue looking at it for 3.8. I'm just not making promises on things being included into the release is all.

[ghost]

@mbabker PR have 2 successfully Test, but conflicts. Close PR?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/7259.}

[mbabker]

Closing the PR just because it has merge conflicts isn't right. If it's been abandoned though, which seems to be the case, and nobody wants to pick it up to get it updated then yes, it should be closed.

[ghost]

Thanks for Answer, @mbabker – if this PR get no Response, it will be closed at 23th July 2017.

[brianteeman]

I will try to find time to redo this

[ghost]

thanks @brianteeman

[brianteeman]

sorry i took a look but its not a simple case of resolving merge conflicts as the base code has changed considerably since this Pr was made. I still think its a good addition but not something I can do

[roland-d]

I will have a look

[brianteeman]

Thanks @roland-d - its all the changes in administrator/components/com_redirect/views/links/tmpl/default.php
that I struggled with

[codexpert]

@ABU would you please check your pr when you back?

On Fri, Jun 23, 2017 at 5:05 PM Brian Teeman ***@***.***> wrote: Thanks @roland-d <https://github.com/roland-d> - its all the changes in administrator/components/com_redirect/views/links/tmpl/default.php that I struggled with — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7259 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAxSE58x1ica4Lw19JWr1j5Ipm-tWfrEks5sG5vpgaJpZM4FKrT8> .

--

…

----- Sent from my iPhone

[roland-d]

Closing this in favor of #16844

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/7259.}