Skip to content

Fixes #6965. Multilang. Article associations. Multiple ID conflict in bootstrap modal #6971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixes #6965. Multilang. Article associations. Multiple ID conflict in bootstrap modal #6971

wants to merge 1 commit into from

Conversation

@ghost
Copy link

@ghost ghost commented May 18, 2015

Please see #6965 for test instructions.
After applying patch you should be able to select associated articles for all languages.

@ghost ghost mentioned this pull request May 18, 2015
Closed
@ghost ghost changed the title Fixes #6965. Multilang. Article associations. Multiple ID conflict in bootstrap modal Fixes #6965. Multilang. Article associations. Multiple CSS-id conflict in bootstrap modal May 18, 2015
@infograf768
Copy link
Member

infograf768 commented May 18, 2015

Good find! @test OK here on a new install..

@joomla-cms-bot joomla-cms-bot changed the title Fixes #6965. Multilang. Article associations. Multiple CSS-id conflict in bootstrap modal Fixes #6965. Multilang. Article associations. Multiple ID conflict in bootstrap modal May 18, 2015
@infograf768 infograf768 mentioned this pull request May 18, 2015
Closed
@infograf768
Copy link
Member

infograf768 commented May 18, 2015

in fact, this is apparently a regression as the issue comes from
#6804

@dgrammatiko
Copy link
Contributor

dgrammatiko commented May 18, 2015

@infograf768 How does modal conflict with associations?
I see associations as chosen items on a select tag:
<select id="jform_associations_en_GB" name="jform[associations][en-GB]" class="chzn-done" style="display: none;">
What am I missing here?

@dgrammatiko
Copy link
Contributor

dgrammatiko commented May 18, 2015

@bertmert Sorry I didn’t realize that this was a PR with code in it. Thanks for taking care of it! I will try to test it later on!

@smz
Copy link
Contributor

smz commented May 18, 2015

@test success
Thank-you, @bertmert

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label May 18, 2015
@infograf768
Copy link
Member

infograf768 commented May 18, 2015

same issue for contact and newsfeeds
Making a PR now for both.

@infograf768 infograf768 mentioned this pull request May 18, 2015
Closed
@infograf768
Copy link
Member

infograf768 commented May 18, 2015

Please test #6983

@smz
Copy link
Contributor

smz commented May 18, 2015

Will do: at this time I have a problem, here, with http://issues.joomla.org/ not loading... 😕

@sovainfo
Copy link
Contributor

sovainfo commented May 18, 2015

No problem for me, loads fine.

@smz
Copy link
Contributor

smz commented May 18, 2015

... must be a local issue... sorry!

@Kubik-Rubik
Copy link
Member

Kubik-Rubik commented May 21, 2015

Merged. Thank you @bertmert!

@Kubik-Rubik Kubik-Rubik added this to the Joomla! 3.4.2 milestone May 21, 2015
johanjanssens pushed a commit to joomlatools/joomla-fork that referenced this pull request Jun 19, 2015
@bertmert @johanjanssens
Fixes joomla#6965. Multilang. Article associations. Multiple ID confl…
d982d28 
…ict in bootstrap modal Fixes joomla#6971
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla! 3.4.2

Development

Successfully merging this pull request may close these issues.

7 participants

@infograf768 @dgrammatiko @smz @sovainfo @Kubik-Rubik @zero-24 @bertmert