Remove link from tooltip

[brianteeman]

PLG_CODEMIRROR_FIELD_VIM_KEYBINDING_DESC="Select this option to make CodeMirror work in Vim mode."

It is never possible to click on that link inside the tooltip - this PR removes the link

[roland-d]

@test: Looks good based on code review.

[peterlose]

It's clickable on mobile devices. But I agree, it should properly be removed

[peterlose]

There's a number of other descriptions, where links are present. Perhaps we should remove these as well to maintain consistency?

[brianteeman]

I didn't spot them can you let me know
On 5 Jan 2015 17:47, "Peter Lose" [email protected] wrote:

There's a number of other descriptions, where links are present. Perhaps
we should remove these as well to maintain consistency?

—
Reply to this email directly or view it on GitHub
#5621 (comment).

[peterlose]

@brianteeman

Thinks that all of them:

PLG_CAPTCHA_NOCAPTCHA_XML_DESCRIPTION (SYS)
PLG_GMAIL_XML_DESCRIPTION (SYS)
PLG_CAPTCHA_NOCAPTCHA_XML_DESCRIPTION
PLG_GMAIL_XML_DESCRIPTION
PLG_SYSTEM_LANGUAGECODE_XML_DESCRIPTION
PLG_SYSTEM_LANGUAGECODE_XML_DESCRIPTION (plugins)
PLG_CAPTCHA_RECAPTCHA_XML_DESCRIPTION
PLG_TINY_FIELD_SKIN_INFO_LABEL

[zero-24]

@brianteeman what do you think if we move the link to
https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.plg_editors_codemirror.ini#L55

so we have
PLG_CODEMIRROR_FIELD_VIM_KEYBINDING_LABEL="<a href="_QQ_"http://en.wikipedia.org/wiki/Vim_%28text_editor%29"_QQ_" target="_QQ_"_blank"_QQ_">Vim</a> Keybinding"

[zero-24]

PLG_CAPTCHA_NOCAPTCHA_XML_DESCRIPTION (SYS)
PLG_GMAIL_XML_DESCRIPTION (SYS)
PLG_CAPTCHA_NOCAPTCHA_XML_DESCRIPTION
PLG_GMAIL_XML_DESCRIPTION
PLG_SYSTEM_LANGUAGECODE_XML_DESCRIPTION
PLG_SYSTEM_LANGUAGECODE_XML_DESCRIPTION (plugins)
PLG_CAPTCHA_RECAPTCHA_XML_DESCRIPTION
PLG_TINY_FIELD_SKIN_INFO_LABEL

All clickable see here e.g. for the gmail.

same applys to the tinyMCE string:

[peterlose]

Ohh okay. Didn't notice that they weren't descriptions for labels. Sorry!

[zero-24]

You are welcome @losedk 👍

[peterlose]

@zero-24 think your proposal is good:

But perhaps it should be for the entire label?

[brianteeman]

It shouldnt be for the whole label and I'm not convinced its a good idea to
have links in labels
On 5 Jan 2015 18:07, "Peter Lose" [email protected] wrote:

@zero-24 https://github.com/zero-24 think your proposal is good:

[image: skaermbillede 2015-01-05 kl 19 06 29]
https://cloud.githubusercontent.com/assets/1738811/5617342/021579f4-950e-11e4-9b6e-f6da46756405.png

But perhaps it should be for the entire label?

—
Reply to this email directly or view it on GitHub
#5621 (comment).

[zero-24]

But perhaps it should be for the entire label?

I agree. So the new string would be:

PLG_CODEMIRROR_FIELD_VIM_KEYBINDING_LABEL="<a href="_QQ_"http://en.wikipedia.org/wiki/Vim_%28text_editor%29"_QQ_" target="_QQ_"_blank"_QQ_">Vim Keybinding</a>"

What do you think @brianteeman ?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5621.}

[rdeutz]

I am going to merge this one because it doesn't makes sense to have it in the tooltip and I have my doubts that a link to wikipedia (to explain what vim is) makes sense at all.

[peterlose]

👍