Skip to content

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Jan 4, 2015

I changed the template how Joomla renders the fields in an backend edit view. In detail, the template generates a div-element with the css class "control-group ". Always with an additional space at the end of the css class "control-group".

My fix sets the css class to "control-group" if there is no additional css class. (without the additional space) else the space is added.

Use the 'renderFieldset' function in the 'JForm' class, Joomla uses the layout in renderfield.php to create the form fields.

The output of this method is not the same as in the Joomla core extensions. This fix makes the output consistent with the Joomla core extension template.

How to test

  • Access a article and e.g. use Firebug to see the HTML Code for a renderd field.
  • use the view-source option of your browser to see the renderd field
  • apply this patch e.g. vie com_patchtester
  • see the same field again

New PR for: #5200 against staging. Code and credit by @Wolf-Rost

@infograf768
Copy link
Member

@test
Looks fine here.

@zero-24
Copy link
Contributor Author

zero-24 commented Jan 5, 2015

Thanks @wilsonge

@peterlose
Copy link
Contributor

@test All good!

@zero-24
Copy link
Contributor Author

zero-24 commented Jan 5, 2015

Thanks @infograf768, @losedk and @wilsonge moving to RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5610.

@infograf768 infograf768 added this to the Joomla! 3.4.0 milestone Jan 6, 2015
infograf768 added a commit that referenced this pull request Jan 6, 2015
Redo for: made output of space conditional -> cause problems with gui tests
@infograf768 infograf768 merged commit 9ddd3a0 into joomla:staging Jan 6, 2015
@zero-24 zero-24 deleted the patch-8 branch January 6, 2015 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants