-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fix Items Count not displayed in categories list (com_contact) #5515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Issue: In com_contact the "Items Count" was not displayed in categories list Cause: wrong parameter name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... not the best parameter name I saw, but I think there is little we can do now.
|
Assume we need the same fix in com_content here: https://github.com/joomla/joomla-cms/blob/staging/components/com_content/views/categories/tmpl/default_items.php#L31 ? |
|
No, that's good. |
|
and in com_newsfeeds too is OK. |
|
Categories all have the same param names though. So why is com_content different to everything else? |
|
So com_newsfeeds and com_contact use one param and com_content and com_weblinks (https://github.com/joomla-extensions/weblinks/blob/master/src/com_weblinks/site/views/categories/tmpl/default_items.php#L31) use a different one?? Something seems really odd here.... |
|
those are the parameters to turn on/off the displaying of items count inside each category when you list all categories. It seems someone some time ago did an odd copy/paste/modify job... |
|
com_weblink I didn't tested... let me 5 minutes to see... |
|
com_weblink is wrong: it should be |
|
Basically each components has his own parameter name (why?) and the name for com_contact is anomalous because it doesn't have 'num_contact' but 'items'. The '_cat' at the end of the names is a mystery only the original coder can explain... |
|
and yes, sorry, com_newsfeeds too has 'items', but it is the same in the .xml file, so it is OK |
|
Initially it was |
|
joomla-extensions/weblinks#22 for com_weblinks |
|
Beez was OK. |
Fix Items Count not displayed in categories list (com_contact)
Issue: In com_contact the "Items Count" was not displayed in categories list
Cause: Wrong parameter name