Skip to content

Conversation

@smz
Copy link
Contributor

@smz smz commented Dec 25, 2014

Issue: In com_contact the "Items Count" was not displayed in categories list
Cause: Wrong parameter name

Issue: In com_contact the "Items Count" was not displayed in categories
list
Cause: wrong parameter name
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... not the best parameter name I saw, but I think there is little we can do now.

@wilsonge
Copy link
Contributor

@smz
Copy link
Contributor Author

smz commented Dec 25, 2014

No, that's good.

@smz
Copy link
Contributor Author

smz commented Dec 25, 2014

and in com_newsfeeds too is OK.

@wilsonge
Copy link
Contributor

Categories all have the same param names though. So why is com_content different to everything else?

@wilsonge
Copy link
Contributor

So com_newsfeeds and com_contact use one param and com_content and com_weblinks (https://github.com/joomla-extensions/weblinks/blob/master/src/com_weblinks/site/views/categories/tmpl/default_items.php#L31) use a different one?? Something seems really odd here....

@smz
Copy link
Contributor Author

smz commented Dec 25, 2014

those are the parameters to turn on/off the displaying of items count inside each category when you list all categories. It seems someone some time ago did an odd copy/paste/modify job...

@smz
Copy link
Contributor Author

smz commented Dec 25, 2014

com_weblink I didn't tested... let me 5 minutes to see...

@smz
Copy link
Contributor Author

smz commented Dec 25, 2014

com_weblink is wrong: it should be show_cat_num_links_cat

@smz
Copy link
Contributor Author

smz commented Dec 25, 2014

Basically each components has his own parameter name (why?) and the name for com_contact is anomalous because it doesn't have 'num_contact' but 'items'. The '_cat' at the end of the names is a mystery only the original coder can explain...

@smz
Copy link
Contributor Author

smz commented Dec 25, 2014

and yes, sorry, com_newsfeeds too has 'items', but it is the same in the .xml file, so it is OK

@smz
Copy link
Contributor Author

smz commented Dec 25, 2014

Initially it was show_item_count for all, but then... ooops... bfc18c6

@smz
Copy link
Contributor Author

smz commented Dec 25, 2014

joomla-extensions/weblinks#22 for com_weblinks

@infograf768
Copy link
Member

Beez was OK.
Obvious error. Merging. Thanks.

infograf768 added a commit that referenced this pull request Dec 25, 2014
Fix Items Count not displayed in categories list (com_contact)
@infograf768 infograf768 merged commit 0cc7016 into joomla:staging Dec 25, 2014
@smz smz deleted the ContactCategoriesItemsCount branch December 25, 2014 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants