Skip to content

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Dec 10, 2014

@Bakual
Copy link
Contributor

Bakual commented Dec 10, 2014

I would just deprecate it. In case someone uses it for whatever reason.

@zero-24
Copy link
Contributor Author

zero-24 commented Dec 10, 2014

I would just deprecate it. In case someone uses it for whatever reason.

hmm it is into the build folder we don't ship this with a install / update. But ok we can deprecate it.

Somthing like:

/**
 * This file will be removed in Joomla! CMS version 4.0. Developers should either supply their own copy of this file if needed.
 */

?

@Hils
Copy link
Contributor

Hils commented Dec 10, 2014

Developers should either supply their own copy of this file if needed.
*/

remove the word 'either' ?

@zero-24
Copy link
Contributor Author

zero-24 commented Dec 10, 2014

Thanks @Hils I have restore the file @Bakual and remove the word either.

@zero-24
Copy link
Contributor Author

zero-24 commented Dec 31, 2014

Can we move this forward? Or is here anything wrong that need a fix?

@brianteeman
Copy link
Contributor

This is a simple fix that just adds a comment block - english is good setting to RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5383.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Jan 13, 2015
@rdeutz rdeutz added this to the Joomla! 3.4.0 milestone Jan 15, 2015
rdeutz added a commit that referenced this pull request Jan 15, 2015
We don't need this file anymore as we don't ship the index.html files anymore

Thanks all :-)
@rdeutz rdeutz merged commit 7c0dd93 into joomla:staging Jan 15, 2015
@zero-24 zero-24 deleted the patch-1 branch January 15, 2015 22:07
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants