Skip to content

Undefined titles on alert messages #5366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2014
Merged

Undefined titles on alert messages #5366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions media/system/js/core-uncompressed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,16 @@ Joomla.renderMessages = function(messages) {
messagesBox.className = 'alert alert-' + type;

// Title
var titleWrapper = document.createElement('h4');
titleWrapper.className = 'alert-heading';
titleWrapper.innerHTML = Joomla.JText._(type);
var title = Joomla.JText._(type);

messagesBox.appendChild(titleWrapper)
// Skip titles with untranslated strings
if (typeof title != 'undefined') {
var titleWrapper = document.createElement('h4');
titleWrapper.className = 'alert-heading';
titleWrapper.innerHTML = Joomla.JText._(type);

messagesBox.appendChild(titleWrapper)
}

// Add messages to the message box
for (var i = typeMessages.length - 1; i >= 0; i--) {
Expand Down
2 changes: 1 addition & 1 deletion media/system/js/core.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.