Changed reCaptcha to use new API

[ghost]

Changed the plugin to use the new API:
https://developers.google.com/recaptcha

[infograf768]

Tested with existing captcha on legacy site
I get an error:
"ERROR: Global site keys are not supported"

[Bakual]

We decided to leave old language strings in (with a deprecated notice) even if they are not used anymore.

Reason is to reduce possible problems with updated language packs and extensions using strings from core extensions. So please don't remove them. You can add a comment before them stating that they're deprecated and no longer used.

[ghost]

@infograph: What do you mean with "existing captcha"? What do you mean with "legacy site"?

[infograf768]

The new API is not B/C with Global Keys.
If we force this update as is, sites may not be B/C.

Maybe we could create a new plugin specially for that Captcha2 ?

[infograf768]

@nonumber
I mean what I said above: when updating with this PR, my keys are not working anymore as they are Global Keys, thus the error

[ghost]

@Bakual : Ok, placed them back.

[ghost]

@infograf768: Sorry, have no idea what "Gloabal Keys" you are talking about. Are you placing a Captcha via some custom code or something?

[infograf768]

See:
https://code.google.com/p/recaptcha/wiki/HowToSetUpRecaptcha

The keys are unique to your domain and sub-domains and will not work for other domains unless you:

Sign up for multiple keys (one for each site)
Create a global key by checking the box for "Enable this key on all domains (global key)"

For example:

The keys for test.com will work on a.test.com, b.test.com, c.test.com and any other sub-domains.
If the option "Enable this key on all domains (global key)" is checked, the keys will work on a.test.com, x.com, y.com and any other domains or sub-domains.

[infograf768]

What I am saying is that I get an error because the new API does NOT accept global Keys.
Google itself tells it (but sorry, I just found it in French)

[Bakual]

As I understand it, this new captcha doesn't work with the old parameters (keys) set. So we would indeed have to deprecate the old plugin and create a new one.
Or add a mode to the plugin which allows to either use the old or new API.

It may also useful to have a postinstall message telling the user to update the plugin. The message could even be only shown if the old plugin/mode is enabled.

[brianteeman]

Shouldnt this be Secret Key now?

[infograf768]

Here is the Google info (in French):

[brianteeman]

shouldnt this be site key now?

[infograf768]

I think it would be better to create a totally new plugin.

[brianteeman]

Made some comments about the use of public and private key in the language strings

[brianteeman]

It may also useful to have a postinstall message telling the user to update the plugin. The message could even be only shown if the old plugin/mode is enabled.

Will both methods co-exist or is the new one replacing the old one at some time.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5315.

[ghost]

I don't have the time to re-write this so that it is a new plugin or supports both the old and new API.
So if anyone wants to fork this , then please go ahead.

[nikosdion]

I think that this should be a new plugin. Moreover, we should fork the ReCaptchaResponse class under a new name, e.g. JReCaptchaResponse. Third party extensions are already using this class (I've seen it before, I can't remember where for the life of me). If we ship it with Joomla! undermanned we will break 3PD extensions.

If Peter has no time to do that, would you like me to handle it?

[brianteeman]

A new plugin called NoCaptcha would make the most sense to me. If the API
keys hadnt changed it could have just been an update but with the changed
keys that would break peoples web sites

On 4 December 2014 at 12:35, Nicholas K. Dionysopoulos <
[email protected]> wrote:

I think that this should be a new plugin. Moreover, we should fork the
ReCaptchaResponse class under a new name, e.g. JReCaptchaResponse. Third
party extensions are already using this class (I've seen it before, I can't
remember where for the life of me). If we ship it with Joomla!
undermanned we will break 3PD extensions.

If Peter has no time to do that, would you like me to handle it?

—
Reply to this email directly or view it on GitHub
#5315 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

[nikosdion]

I have forked the plugin. Please see gh-5323.

[ghost]

Ok, great. So this one is closed.
Thanks for taking this over.