[6.0] Event Deprecation code comments#47337
Conversation
|
Can you change it to explicit 7.0 (or just 7) as we can't remove it in another version than 7.0.0. The .x assumes in any version of the 7 series. |
|
@laoneo the actual deprecation notice is @deprecated 4.3 will be removed in 7.0 and i just changed the existing comment from 5 to 7 but i can of course change it to 7.0 in the comment |
|
Then its more clear. Thanks |
|
Why is this PR made for the 6.0-dev branch? |
|
because i have absolutely no idea what branch it should be against - you said there wouldnt be another 5.4 release so i guessed it should be for 6.0. or did you say there wouldnt be another 6.0 release. With so many branches its very confusing |
@i think you mixed it up. I said there might be no 6.0.4 as there is 6.1.0 stable soon. But of course there will be 5.4 releases. 5.4 is in bug fix mode until October when 6.2.0 comes, and then one more year 5.4 security fix mode. As the referenced PR was merged into 5.4, I would also expect this one to be for 5.4. |
|
ok i will rebase it to j5 |
|
closing - will reopen for 5 |
|
@richard67 I have re=opened this for 6.0 as some of the comments relate to another PR #46367 which was for 6.0 Otherwise I would need to split this into two PR for 5.4 and 6.0 and for just a comment update it seems unnecessary |
|
We changed to the target versions to 7 only in the 6 branch (#46367). So I would do this only in 6 as well. |
I see. I was not aware of that other PR. |
|
Thanks @brian and for reviews |
Pull Request resolves # .
Summary of Changes
#45818 Extend Events related deprecation till Joomla 7.
This pr updates the code comments to reflect that changed deprecation
Testing Instructions
code review only
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed