Skip to content

[6.0] Event Deprecation code comments#47337

Merged
Bodge-IT merged 6 commits intojoomla:6.0-devfrom
brianteeman:event_deprecations
Mar 9, 2026
Merged

[6.0] Event Deprecation code comments#47337
Bodge-IT merged 6 commits intojoomla:6.0-devfrom
brianteeman:event_deprecations

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

#45818 Extend Events related deprecation till Joomla 7.
This pr updates the code comments to reflect that changed deprecation

Testing Instructions

code review only

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo
Copy link
Copy Markdown
Member

laoneo commented Mar 9, 2026

Can you change it to explicit 7.0 (or just 7) as we can't remove it in another version than 7.0.0. The .x assumes in any version of the 7 series.

@brianteeman
Copy link
Copy Markdown
Contributor Author

@laoneo the actual deprecation notice is @deprecated 4.3 will be removed in 7.0 and i just changed the existing comment from 5 to 7 but i can of course change it to 7.0 in the comment

@laoneo
Copy link
Copy Markdown
Member

laoneo commented Mar 9, 2026

Then its more clear. Thanks

@richard67
Copy link
Copy Markdown
Member

Why is this PR made for the 6.0-dev branch?

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Mar 9, 2026

because i have absolutely no idea what branch it should be against - you said there wouldnt be another 5.4 release so i guessed it should be for 6.0. or did you say there wouldnt be another 6.0 release. With so many branches its very confusing

@richard67
Copy link
Copy Markdown
Member

because i have absolutely no idea what branch it should be against - you said there wouldnt be another 5.4 release so i guessed it should be for 6.0. or did you say there wouldnt be another 6.0 release. With so many branches its very confusing

@i think you mixed it up. I said there might be no 6.0.4 as there is 6.1.0 stable soon. But of course there will be 5.4 releases. 5.4 is in bug fix mode until October when 6.2.0 comes, and then one more year 5.4 security fix mode.

As the referenced PR was merged into 5.4, I would also expect this one to be for 5.4.

@brianteeman
Copy link
Copy Markdown
Contributor Author

ok i will rebase it to j5

@brianteeman brianteeman changed the base branch from 6.0-dev to 5.4-dev March 9, 2026 13:57
@brianteeman
Copy link
Copy Markdown
Contributor Author

closing - will reopen for 5

@brianteeman brianteeman closed this Mar 9, 2026
@brianteeman brianteeman deleted the event_deprecations branch March 9, 2026 13:58
@brianteeman brianteeman restored the event_deprecations branch March 9, 2026 14:03
@brianteeman brianteeman reopened this Mar 9, 2026
@brianteeman brianteeman changed the base branch from 5.4-dev to 6.0-dev March 9, 2026 14:04
@brianteeman
Copy link
Copy Markdown
Contributor Author

@richard67 I have re=opened this for 6.0 as some of the comments relate to another PR #46367 which was for 6.0

Otherwise I would need to split this into two PR for 5.4 and 6.0 and for just a comment update it seems unnecessary

@laoneo
Copy link
Copy Markdown
Member

laoneo commented Mar 9, 2026

We changed to the target versions to 7 only in the 6 branch (#46367). So I would do this only in 6 as well.

@richard67
Copy link
Copy Markdown
Member

We changed to the target versions to 7 only in the 6 branch (#46367). So I would do this only in 6 as well.

I see. I was not aware of that other PR.

Copy link
Copy Markdown
Contributor

@tecpromotion tecpromotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Bodge-IT Bodge-IT added this to the Joomla! 6.0.4 milestone Mar 9, 2026
@Bodge-IT Bodge-IT merged commit a547e10 into joomla:6.0-dev Mar 9, 2026
52 checks passed
@Bodge-IT
Copy link
Copy Markdown
Contributor

Bodge-IT commented Mar 9, 2026

Thanks @brian and for reviews

@brianteeman brianteeman deleted the event_deprecations branch March 9, 2026 18:53
@richard67
Copy link
Copy Markdown
Member

Thanks @brian and for reviews

@Bodge-IT You pinged the wrong Brian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants