Skip to content

[6.0] Adapter should have in install routine always the current manifest#46760

Merged
softforge merged 2 commits intojoomla:6.0-devfrom
Digital-Peak:installer
Jan 27, 2026
Merged

[6.0] Adapter should have in install routine always the current manifest#46760
softforge merged 2 commits intojoomla:6.0-devfrom
Digital-Peak:installer

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Jan 26, 2026

Summary of Changes

When updating two extension at the same time, then files from the first extension are copied to the second one because of caching an adapter instance. Relevant pr is #43792.

Testing Instructions

  • Install two older versions of a plugin which have an update site or install two free ones from DPCalendar like this and this).
  • Open /administrator/index.php?option=com_installer&view=update and click on "Check for updates"
  • Select the two plugins and hit the "Update" button

BEFORE DOING THE SECOND TEST WITH THE PATCH, UNINSTALL THE EXTENSIONS FIRST!

Actual result BEFORE applying this Pull Request

One folder, where the plugin is installed to, contains its own manifest file only. The other contains it's own manifest file and the one from the other plugin.

Expected result AFTER applying this Pull Request

Both plugin installation folders do only contain their own installable files.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@dautrich
Copy link

I have tested this item ✅ successfully on 27f31ef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46760.

@Bodge-IT Bodge-IT added the PBF Pizza, Bugs and Fun label Jan 26, 2026
@mariantanase
Copy link

mariantanase commented Jan 27, 2026

I have tested this item ✅ successfully on 27f31ef

The behavior is as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46760.

Before:

jcalpro-before jevents-before

After:

jevents-after jcalpro-after

@tecpromotion
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46760.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 27, 2026
Co-authored-by: Brian Teeman <brian@teeman.net>
@Bodge-IT Bodge-IT added this to the Joomla! 6.0.3 milestone Jan 27, 2026
@laoneo laoneo removed the PBF Pizza, Bugs and Fun label Jan 27, 2026
@softforge softforge merged commit cd5d1fe into joomla:6.0-dev Jan 27, 2026
51 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 27, 2026
@softforge
Copy link
Contributor

Thank you @laoneo for the pr and the test instructions. Thank you testers and all involved in getting this release blocker in

@laoneo laoneo deleted the installer branch January 27, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants