Conversation
|
I have tested this item ✅ successfully on 06fa1b2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46757. |
|
I have tested this item ✅ successfully on 06fa1b2 For test 2: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46757. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46757. |
|
TL;DR The 2nd folder now works, but the 1st one no longer does. @dgrammatiko Could you please check? #46717 states The font is previewed in both tests. ❌ Final test before merge with JBT and used Ubuntu TTF font
|
|
That’s correct, the modern templates expect all the static assets to be served from the media folder (compatibility with the public folder and better security). In sort your test was correct and the results are the expected ones |
|
As discussed yesterday in the maintainer meeting: Old templates load their assets from the template folder, new templates (inheritable) use the media folder, so the PR is fine and can be merged. |
|
Thank you @dgrammatiko for your contribution. Thank you @brianteeman and @krishnaGandhi11 for testing. |
Pull Request for Issue #46717 .
Summary of Changes
Adjust the code so that Fonts follow the logic of Modern/legacy templates
Testing Instructions
Follow the instruction of the issue #46717
Actual result BEFORE applying this Pull Request
Broken link is logged into the browser's console, no font preview
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed