Skip to content

[5.4] Fix fonts URL#46757

Merged
muhme merged 5 commits intojoomla:5.4-devfrom
dgrammatiko:5.4-dev/fonts
Jan 29, 2026
Merged

[5.4] Fix fonts URL#46757
muhme merged 5 commits intojoomla:5.4-devfrom
dgrammatiko:5.4-dev/fonts

Conversation

@dgrammatiko
Copy link
Contributor

Pull Request for Issue #46717 .

Summary of Changes

Adjust the code so that Fonts follow the logic of Modern/legacy templates

Testing Instructions

Follow the instruction of the issue #46717

Actual result BEFORE applying this Pull Request

Broken link is logged into the browser's console, no font preview

Expected result AFTER applying this Pull Request

Works

Screenshot 2026-01-25 at 2 12 38 PM

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 06fa1b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46757.

@krishnagandhicode
Copy link
Contributor

I have tested this item ✅ successfully on 06fa1b2

For test 1:
Fonts located in /media/templates/site/cassiopeia/fonts
Font preview works correctly, no 404 errors in browser console

For test 2:
Fonts located in /templates/cassiopeia/fonts
404 error occurs (expected for modern templates)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46757.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46757.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 26, 2026
@muhme
Copy link
Contributor

muhme commented Jan 26, 2026

TL;DR The 2nd folder now works, but the 1st one no longer does. @dgrammatiko Could you please check? #46717 states The font is previewed in both tests.

❌ Final test before merge with JBT and used Ubuntu TTF font

  • Executing mkdir media/templates/site/cassiopeia/fonts administrator/templates/atum/fonts media/templates/administrator/atum/fonts first
  • Before PR, seen rendering is working in templates/cassiopeia/fonts dir, but not is the font only in media/templates/site/cassiopeia/fonts dir and 404 Not Found in JS console log
  • Same, working for administrator/templates/atum/fonts, but not working if font is only in media/templates/administrator/atum/fonts folder
  • Applied PR with Patch Tester
    • ✅ Font from media/templates/site/cassiopeia/fonts dir only is correctly rendered and no 404 Not Found anymore
    • ❌ Font from templates/cassiopeia/fonts dir is not rendered and 404 Not Found
    • ✅ Font from media/templates/administrator/atum/fonts only is correctly rendered and no 404 Not Found anymore
    • ❌ Font from administrator/templates/atum/fonts dir only is not rendered and 404 Not Found

@dgrammatiko
Copy link
Contributor Author

That’s correct, the modern templates expect all the static assets to be served from the media folder (compatibility with the public folder and better security). In sort your test was correct and the results are the expected ones

@muhme muhme added RMDQ ReleaseManagerDecisionQueue and removed RTC This Pull Request is Ready To Commit labels Jan 27, 2026
@richard67 richard67 added RTC This Pull Request is Ready To Commit and removed RMDQ ReleaseManagerDecisionQueue labels Jan 28, 2026
@muhme
Copy link
Contributor

muhme commented Jan 29, 2026

As discussed yesterday in the maintainer meeting: Old templates load their assets from the template folder, new templates (inheritable) use the media folder, so the PR is fine and can be merged.

@muhme muhme merged commit 6b102fe into joomla:5.4-dev Jan 29, 2026
69 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 29, 2026
@muhme muhme added this to the Joomla! 5.4.3 milestone Jan 29, 2026
@muhme
Copy link
Contributor

muhme commented Jan 29, 2026

Thank you @dgrammatiko for your contribution. Thank you @brianteeman and @krishnaGandhi11 for testing.

@dgrammatiko dgrammatiko deleted the 5.4-dev/fonts branch January 29, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants