Skip to content

[5.4] Add legacy label to mod_articles_archived#46626

Merged
muhme merged 7 commits intojoomla:5.4-devfrom
drmenzelit:5.4-dev
Jan 8, 2026
Merged

[5.4] Add legacy label to mod_articles_archived#46626
muhme merged 7 commits intojoomla:5.4-devfrom
drmenzelit:5.4-dev

Conversation

@drmenzelit
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Added "legacy" to mod_articles_archived since that module has been replaced with mod_articles

Testing Instructions

When creating a new module in the backend the Modul Articles - Archived should display (legacy) in the title

Actual result BEFORE applying this Pull Request

No legacy in title

Expected result AFTER applying this Pull Request

legacy in title

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.4-dev labels Jan 2, 2026
@tecpromotion tecpromotion changed the title Add legacy label to mod_articles_archived [5.4] Add legacy label to mod_articles_archived Jan 2, 2026
@richard67 richard67 added the bug label Jan 2, 2026
@richard67
Copy link
Member

@tecpromotion Is this something for a patch version? Or should it be fixed with 6.1?

@brianteeman
Copy link
Contributor

Changing or deleting a language key is considered a backwards compatibility break. Adding new ones is not. Substantially changing the meaning associated with a language key is a compatibility break. Rephrasing something for a more accurate description or proper en-GB grammar is not.

@drmenzelit
Copy link
Contributor Author

The other "legacy" labels were introduced in 5.3, sadly Articles -Archived was missing although Quy pointed to it:
#44366 (comment)

drmenzelit and others added 4 commits January 2, 2026 18:45
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
@drmenzelit
Copy link
Contributor Author

Thank you @brianteeman for reviewing

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 6c92ccf

Changes are good, I will let maintainers decide which version is appropriate


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46626.

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 6c92ccf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46626.

@tecpromotion
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46626.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 2, 2026
@richard67 richard67 added this to the Joomla! 5.4.3 milestone Jan 2, 2026
@muhme
Copy link
Contributor

muhme commented Jan 8, 2026

✅ Final test before merge with JBT

  • Seen 'Articles - Archived' before PR in Extension list and Site Modules selection
  • Applied PR with gh pr checkout 46625
  • Seen 'Articles - Archived (Legacy)' in both places and seen the added 'superseded' sentence.

@muhme muhme merged commit a3400f7 into joomla:5.4-dev Jan 8, 2026
69 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 8, 2026
@muhme
Copy link
Contributor

muhme commented Jan 8, 2026

Thank you @drmenzelit for your contribution. Thank you @brianteeman and @tecpromotion for reviewing and testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants