[5.4] Don't generate unique title and alias for Smart Search filters on “Save as Copy” - Revert PR 46081

[richard67]

Pull Request for Issue # .

Alternative to PR #46449 .

Summary of Changes

This pull request (PR) reverts PR #46081 , which has been merged before 5.4.1-rc1 and so is part of that pre-release, but not has been released yet with a stable release.

The PR was classified as bug fix as its associated issue #43969 was classified as bug, but that was possibly wrong.

Looking deeper into it, I meanwhile think it is a new feature and so should have been made for 6.1-dev.

When I had set RTC for the PR, I was not aware of it, so it is partly my mistake.

The PR has some issues which would be fixed with PR #46449 , but it still doesn't result in an ideal solution, e.g. it still needs to access the input in the model, see the review discussion in that PR.

So the clean way would be to revert PR #46081 before 5.4.1 stable, re-open issue #43969 and change that from bug to feature and implement a better solution for 6.1-dev.

For the revert part I have created this PR here.

Testing Instructions

1. Go to "Administrator → Components → Smart Search → Filters".
2. Create a new filter if none exists yet.
3. Select a filter to edit.
4. Use "Save as Copy".
5. Go back to the list view.
6. Check if the alias is shown in the Search Filter list.

Actual result BEFORE applying this Pull Request

A new filter is created with new title and alias.

The alias is shown in the Search Filter list.

Expected result AFTER applying this Pull Request

An error alert "Save failed with the following error: Another Filter has the same alias." is shown.

The alias is not shown in the Search Filter list.

This is the same behaviour as with 5.4.0 or previous versions.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[ceford]

I have tested this item ✅ successfully on 7e64d49

Without the patch the alias is shown in the Search Filter list. With the patch it is not shown. It could be useful to show the alias in either case.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46453.}

[richard67]

Without the patch the alias is shown in the Search Filter list. With the patch it is not shown. It could be useful to show the alias in either case.

@ceford Yes, that should be part of the solution for 6.1.

P.S.: I've updated the testing instructions to show that change, too.

[muhme]

This PR was applied with gh and the two files were compared. They were changed in PR 46081, which is to be withdrawn, so that the files now have the same content as before PR 46081 with 95a83b5.

• administrator/components/com_finder/src/Model/FilterModel.php
• administrator/components/com_finder/tmpl/filters/default.php

[muhme]

I have tested this item ✅ successfully on 7e64d49

Tested with JBT and applied PR with Patch Tester

• 'Save as Copy' fails again with the red error 'Another Filter has the same alias.'
• Creating a new search filter with different name is still working

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46453.}

[muhme]

Thank you @richard67 for this PR. Thank you @ceford for testing.