[5.4] check if state is initialized in content CategoryModel

[heelc29]

Pull Request for Issue #46311 .

Summary of Changes

Check if model state is initialized before access
This is regression from PR #45704

Testing Instructions

Follow issue description or add following code to components\com_content\tmpl\featured\default.php

$app   = \Joomla\CMS\Factory::getApplication();
$model = $app->bootComponent('com_content')->getMVCFactory()
    ->createModel('Category', 'Site', ['ignore_request' => false]);
$category = $model->getCategory();
var_dump($category::class);

Actual result BEFORE applying this Pull Request

Exception

Expected result AFTER applying this Pull Request

Should work again (like J5.3)

Link to documentations

Please select:

• No documentation changes for docs.joomla.org needed
• No documentation changes for manual.joomla.org needed

[chmst]

Both codes work, so I give a successful test. I would keep the old-fashioned variant, it is easier to read. This model will be often read by extension developers who are not familiar with newest PHP syntax. If the new variant is used, a comment could be helpful.

[chmst]

I have tested this item ✅ successfully on 8c8290d

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46316.}

[joomdonation]

I have tested this item ✅ successfully on b8a1198

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46316.}

[joomdonation]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46316.}

[richard67]

Thanks @heelc29 for the fix, and @chmst and @joomdonation for testing.