[6.1] Migrate from ESLint to Biome#46125
Conversation
|
Did you add a line length? Would probably make sense to increase it, to have less changes in this pr. |
|
@laoneo The default is 80, which I believe is the same as ESLint. Happy to increase this if you'd like a specific value, although 80 is generally considered a good number. |
|
If I remember correctly we were going in the past with 150. But can't find any evidence right now. Perhaps @wilsonge can shed some light here. Personally, I find 80 to close. |
|
These here are definitely incorrect. |
|
@laoneo Biome doesn't support |
|
Looks like then, otherwise there is a better alternative. |
|
There is still an issue with the line length, changes like this one look wrong to me. |
|
@laoneo It wraps on a new line due to the default 80 character limit per line. |
|
I've just realised that eslint isn't even being properly used. All rules were removed in (#45784) other than |
|
Nice. JS and vue files do look much better now. |
|
Thanks for the work on this everyone. Just a little additional push to get this over the line is needed. Moved to 6.1 as 6.0 only in bugfix mode. |
Summary of Changes
This migrates linting from ESLint to Biome, for 2 simple reasons:
As part of this PR, I've also run the built-in formatter to try and use concise coding standards across the board.
@Fedik @dgrammatiko Would be nice to get your thoughts