[6.1] house cleaning - removal deprecated helper and function #46028
[6.1] house cleaning - removal deprecated helper and function #46028hans2103 wants to merge 12 commits intojoomla:6.1-devfrom
Conversation
|
Looks good for me. When the icon.php is removed, we have an empty folder: component/com_content/com_content. |
@chmst Sure we have an empty folder? When you remove the last file in a folder in git, the the folder is also removed. Check out the branch of this PR in a git client or check the package created by drone for this PR. There will not be that empty folder. |
|
I have tested this item ✅ successfully on 7599f5e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46028. |
|
I would also suggest to create a class alias here to the JHtmlIcon class. Like this it will trigger only a static function call warning and not produce a fatal error that the class doesn't exist. |
This "bug" is out of scope for my PR. |
|
Solved merge conflict |
|
We can't deprecate in a bugfix version, so it has to be included in 6.1 @HLeithner & @tecpromotion |
HLeithner
changed the title
Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>
| COM_CONTENT_ERROR_ARTICLE_NOT_FOUND="Article not found" | ||
| COM_CONTENT_ERROR_LOGIN_TO_VIEW_ARTICLE="Please login to view the article" | ||
| COM_CONTENT_ERROR_PARENT_CATEGORY_NOT_FOUND="Parent category not found" | ||
| COM_CONTENT_ERROR_PRINT_POPUP="Sorry, Joomla no longer supports print_popup" |
There was a problem hiding this comment.
This needs proper deprecation too.
There was a problem hiding this comment.
fine... closing the issue so someone else can solve it with proper deprecation notions.
7 participants
Pull Request for Issue #46026 .
Summary of Changes
This PR will remove the deprecated helper icons.php and associated language string.
It will also remove the deprecated function print_screen in the new Helper/icons
Testing Instructions
before and after doesn't matter in this case... both removed helper and function are not used in J6 anymore and even the layout called from the non-used function print_screen in the new helper does not exist.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed