Skip to content

[5.4] Move associations alert#46011

Merged
muhme merged 2 commits intojoomla:5.4-devfrom
brianteeman:associations
Aug 29, 2025
Merged

[5.4] Move associations alert#46011
muhme merged 2 commits intojoomla:5.4-devfrom
brianteeman:associations

Conversation

@brianteeman
Copy link
Contributor

Pull Request for Issue #33841 .

Summary of Changes

Move the message inside the fieldset so we dont have the ugly empty fieldset

Testing Instructions

This is a js change so either use a prebuilt package or apply the pr and run npm build:js

Install an additional language and enable the language filter plugin
Go to any article/menu etc and make sure the language is set to ALL
Go to the associations tab and check the results

Change the language of the item to anything other than ALL and verify that the associations fields are now displayed and the message is not

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: BrianTeeman <brian@teeman.net>
@exlemor
Copy link

exlemor commented Aug 29, 2025

I have tested this item ✅ successfully on 362f8af

I have tested this successfully! Nice and easy one! Thanks @brianteeman!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46011.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 362f8af


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46011.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46011.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 29, 2025
@muhme muhme merged commit 369756c into joomla:5.4-dev Aug 29, 2025
40 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 29, 2025
@muhme muhme added this to the Joomla! 5.4.0 milestone Aug 29, 2025
@muhme
Copy link
Contributor

muhme commented Aug 29, 2025

✅ Final check before merge with JBT graft, installed German as extension, reproduced the problem and checked the fix

@muhme
Copy link
Contributor

muhme commented Aug 29, 2025

Thank you @brianteeman for your contribution. Thank you @exlemor and @richard67 for testing.

@brianteeman brianteeman deleted the associations branch August 29, 2025 17:43
rdeutz pushed a commit to rdeutz/joomla-cms that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.4-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants