Skip to content

[5.3] Add check if fields exist in versioning#46009

Merged
rdeutz merged 1 commit intojoomla:5.3-devfrom
bembelimen:5.3/versioning-table-column-fix
Aug 29, 2025
Merged

[5.3] Add check if fields exist in versioning#46009
rdeutz merged 1 commit intojoomla:5.3-devfrom
bembelimen:5.3/versioning-table-column-fix

Conversation

@bembelimen
Copy link
Contributor

Summary of Changes

With #45597 checked_out + checked_out_time are set when restoring a version history. But this code is assuming that every extension is using this fields. This PR makes checks if the field exist and uses the proper alias.

Testing Instructions

See the testing instruction in #45597 it should still work the same.

Actual result BEFORE applying this Pull Request

Hard coded way of resetting fields

Expected result AFTER applying this Pull Request

Date&User are still reset when fields are there but in a flexible way.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 300c0a1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46009.

@exlemor
Copy link

exlemor commented Aug 29, 2025

I have tested this item ✅ successfully on 300c0a1

I've tested this successfully - thanks @bembelimen!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46009.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46009.

@richard67 richard67 changed the title [5.3] Add check if fields exist in versioning [5.3] Add check if fields exist in versioning Aug 29, 2025
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 29, 2025
@rdeutz rdeutz merged commit d5385e3 into joomla:5.3-dev Aug 29, 2025
40 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 29, 2025
@richard67 richard67 added this to the Joomla! 5.3.4 milestone Aug 29, 2025
This was referenced Aug 29, 2025
rdeutz pushed a commit to rdeutz/joomla-cms that referenced this pull request Sep 2, 2025
@bembelimen bembelimen deleted the 5.3/versioning-table-column-fix branch December 8, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants