[5.3] Add check if fields exist in versioning#46009
Merged
rdeutz merged 1 commit intojoomla:5.3-devfrom Aug 29, 2025
Merged
Conversation
Member
|
I have tested this item ✅ successfully on 300c0a1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46009. |
|
I have tested this item ✅ successfully on 300c0a1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46009. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46009. |
This was referenced Aug 29, 2025
rdeutz
pushed a commit
to rdeutz/joomla-cms
that referenced
this pull request
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
With #45597 checked_out + checked_out_time are set when restoring a version history. But this code is assuming that every extension is using this fields. This PR makes checks if the field exist and uses the proper alias.
Testing Instructions
See the testing instruction in #45597 it should still work the same.
Actual result BEFORE applying this Pull Request
Hard coded way of resetting fields
Expected result AFTER applying this Pull Request
Date&User are still reset when fields are there but in a flexible way.