Merged
Conversation
This PR removes a duplicate loading of the language string JFIELD_MEDIA_LAZY_LABEL Additionally I have alpha sorted the strings. Should make it easier in the future if a string is added to prevent it being added twice. Sorry I have no idea where this is used so testing by code review or let me know where it is used and I can update the test instructions Signed-off-by: BrianTeeman <brian@teeman.net>
richard67
reviewed
Aug 29, 2025
richard67
approved these changes
Aug 29, 2025
muhme
approved these changes
Aug 29, 2025
Contributor
muhme
left a comment
muhme
left a comment
There was a problem hiding this comment.
Self-checked with sort -u - gives the same result.
Contributor
|
Thank you @brianteeman for your contribution. |
rdeutz
pushed a commit
to rdeutz/joomla-cms
that referenced
this pull request
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR removes a duplicate loading of the language string JFIELD_MEDIA_LAZY_LABEL
Additionally I have alpha sorted the strings. Should make it easier in the future if a string is added to prevent it being added twice.
Testing Instructions
Sorry I have no idea where this is used so testing by code review or let me know where it is used and I can update the test instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed