Skip to content

[6.0] Fix language auto-loading without Application in CMSPlugin#45993

Merged
softforge merged 6 commits intojoomla:6.0-devfrom
Fedik:plg-autolanguage-fix
Aug 30, 2025
Merged

[6.0] Fix language auto-loading without Application in CMSPlugin#45993
softforge merged 6 commits intojoomla:6.0-devfrom
Fedik:plg-autolanguage-fix

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Aug 27, 2025

Pull Request for Issue # .

Summary of Changes

Fix language auto-loading when plugin does not provide Application.

Testing Instructions

Apply patch.
Create a Task for "Global Check-in"

Actual result BEFORE applying this Pull Request

The plugin is untranslated

Expected result AFTER applying this Pull Request

The plugin is translated

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference:

@tecpromotion
Copy link
Contributor

tecpromotion commented Aug 27, 2025

I have tested this item ✅ successfully on 0aed622


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45993.

Actual result BEFORE applying this Pull Request
2025-08-27_17-08-27
2025-08-27_17-07-58

Result AFTER applying this Pull Request
2025-08-27_17-09-33
2025-08-27_17-09-09

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 751c624


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45993.

@joomdonation
Copy link
Contributor

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45993.

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 4fa12c2

I get an error message with the patch tester.

The file marked for modification does not exist: phpstan-baseline.neon

Replace CMSPlugin.php manually with https://github.com/joomla/joomla-cms/blob/4fa12c225a655042c6f2218e6486a5944b2a7ec4/libraries/src/Plugin/CMSPlugin.php


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45993.

@Fedik
Copy link
Member Author

Fedik commented Aug 27, 2025

One more test please, when all test passes, thanks :)

@exlemor
Copy link

exlemor commented Aug 27, 2025

I have tested this item ✅ successfully on 99fc571

I have tested this successfully via the Download package. Thanks @Fedik!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45993.

@joomdonation
Copy link
Contributor

RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45993.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 28, 2025
@richard67
Copy link
Member

I've allowed myself to fix the conflict in the phpstan-baseline.neon file. As this did not change anything on the code, RTC is still valid.

@softforge softforge added this to the Joomla! 6.0.0 milestone Aug 30, 2025
@softforge softforge merged commit 203ba0c into joomla:6.0-dev Aug 30, 2025
30 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 30, 2025
@softforge
Copy link
Contributor

Thank you, @Fedik, for your work on fixing the bug, and @richard67 for fixing the conflict. Excellent work. And of course the testers for your part in the process.

@Fedik Fedik deleted the plg-autolanguage-fix branch August 30, 2025 12:19
rdeutz pushed a commit to rdeutz/joomla-cms that referenced this pull request Sep 2, 2025
…mla#45993)

* Fix language autoloading without application

* phpstan

* test

* test

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants