Skip to content

[6.0] Add CSS to Cassiopeia for the refactored mod_menu#45930

Merged
softforge merged 5 commits intojoomla:6.0-devfrom
drmenzelit:mod_menu6
Aug 30, 2025
Merged

[6.0] Add CSS to Cassiopeia for the refactored mod_menu#45930
softforge merged 5 commits intojoomla:6.0-devfrom
drmenzelit:mod_menu6

Conversation

@drmenzelit
Copy link
Contributor

Summary of Changes

With #45922 the standard view of mod_menu was refactored.
This PR adds some CSS in Cassiopeia to display the menu correctly.

Testing Instructions

Create different menu items, create a menu module with default layout, test it in different positions.

Actual result BEFORE applying this Pull Request

When the menu is in the position "menu" the submenu makes a shift: #45922 (comment)

Expected result AFTER applying this Pull Request

The submenu opens correctly: #45922 (comment)

There is still a problem with focus-visible on the button (off center), but I haven't a good solution by now (we have the same problem also in Metismenu)

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev labels Aug 17, 2025
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on cb16b88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930.

@drmenzelit
Copy link
Contributor Author

Sorry @brianteeman , can you please test again? It was something wrong with the link color on menus on the sidebar and with the color of the focus-visible

@brianteeman
Copy link
Contributor

I'm wondering if this should not be in the mod_menu css

@LadySolveig
Copy link
Contributor

It could well be that the accent colour is set globally.
I don't want to dictate to anyone how the focus colour should be set. I still think that ultimately it depends very much on the template.

But that's just my opinion.

@LadySolveig
Copy link
Contributor

LadySolveig commented Aug 17, 2025

I have tested this item ✅ successfully on e15a50c

Thank you very much for your quick support! 💚


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930.

@exlemor
Copy link

exlemor commented Aug 18, 2025

@drmenzelit @LadySolveig

I fear/feel that I have may found a bug in PR #45930, (or IF outside of the PR scope, still something that I think should be checked)?

When I put the Default Menu in many positions as requested, I found that when it is in below-top position on CASSIOPEIA, I got a bleed through due to an incorrectly or unset z-index...

ScreenFloat Shot of Safari on 2025-08-18 at 14-03-55

FYI, (while this may not be HOW you want it fixed, if I add z-index:1 (or higher) to .mod-list li .mod-menu__sub in template.min.css, the issue is resolved... )

Co-authored-by: Martina  Scholz <64533137+LadySolveig@users.noreply.github.com>
@LadySolveig
Copy link
Contributor

LadySolveig commented Aug 18, 2025

I found another unintended behaviour with the position that @exlemor tested.
However, as this also affects the Metis menu, I will open a new PR for it.
grafik
Could you please test again. @exlemor

@exlemor
Copy link

exlemor commented Aug 18, 2025

I found another unintended behaviour with the position that @exlemor tested. However, as this also affects the Metis menu, I will open a new PR for it. grafik Could you please test again. @exlemor

yes gladly and you beat me to it, I was going to write about the grey focus/active glitch ;)

@ChristineWk
Copy link

ChristineWk commented Aug 18, 2025

I can confirm result from Lady Solveig.

Not part of the PR, but FYI:
Version: 6.0.0-alpha4-dev has problems after loaded extensions. Message:
0 Cannot access protected property Joomla\CMS\Application\AdministratorApplication::$input
With Version: 6.0.0-alpha3-dev (a colleague's) doesn't have this problem.

I've now installed 6.0.0-alpha4-dev+pr.45930.
Sorry if I can't help more.
Menus look like this:
Screenshot 2025-08-18 221626

@exlemor
Copy link

exlemor commented Aug 18, 2025

I have tested this item ✅ successfully on d4f176a

I have tested successfully the issue/fix of this PR. Thanks @drmenzelit (@LadySolveig and @brianteeman)

(what I found will be covered in a new PR)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930.

@ChristineWk
Copy link

I have tested this item ✅ successfully on d4f176a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930.

@ChristineWk
Copy link

In case anyone is interested:
As mentioned above, when calling installed extensions, the following message appears:
Cannot access protected property Joomla\CMS\Application\AdministratorApplication::$input
It should be changed from:
Factory::getApplication()->input->get
to:
Factory::getApplication()->getInput->input->get
(This will probably be changed with J6 Alpha4).

@bembelimen bembelimen added the bug label Aug 20, 2025
@richard67
Copy link
Member

Cannot access protected property Joomla\CMS\Application\AdministratorApplication::$input

@ChristineWk This is a known issue we have observed with 3rd party extensions. Do you have some installed on your site? If yes, which?

@richard67
Copy link
Member

To all testers: Have you also checked that the metismenu is not broken?

@richard67 richard67 removed the bug label Aug 23, 2025
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 23, 2025
@richard67 richard67 added the bug label Aug 23, 2025
@ChristineWk
Copy link

ChristineWk commented Aug 23, 2025

The changes are for the standard Joomla menu.

It affected Phoca extensions, but it was version 6.0.0-alpha4-dev. I informed Jan about it and therefore copied his changed code (see above) here. It should work with a newer beta version.

@richard67
Copy link
Member

@ChristineWk I know that the changes made by this PR here are for the standard menu. But the standard menu and the metismenu might share some class names in the markup, so CSS might be applied on both.

@richard67 richard67 dismissed LadySolveig’s stale review August 23, 2025 13:06

The requested change (z-index) has been implemented with commit d4f176a .

@softforge softforge added this to the Joomla! 6.0.0 milestone Aug 30, 2025
@softforge softforge merged commit cc988a4 into joomla:6.0-dev Aug 30, 2025
30 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 30, 2025
@softforge
Copy link
Contributor

thank you @drmenzelit and @LadySolveig for your code and testing and to the other testers

rdeutz pushed a commit to rdeutz/joomla-cms that referenced this pull request Sep 2, 2025
* Add CSS for the corrected mod_menu

* Corrected focus

* Corrected z-index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants