[6.0] Add CSS to Cassiopeia for the refactored mod_menu#45930
[6.0] Add CSS to Cassiopeia for the refactored mod_menu#45930softforge merged 5 commits intojoomla:6.0-devfrom
Conversation
|
I have tested this item ✅ successfully on cb16b88 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930. |
|
Sorry @brianteeman , can you please test again? It was something wrong with the link color on menus on the sidebar and with the color of the focus-visible |
|
I'm wondering if this should not be in the mod_menu css |
|
It could well be that the accent colour is set globally. But that's just my opinion. |
|
I have tested this item ✅ successfully on e15a50c Thank you very much for your quick support! 💚 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930. |
|
I fear/feel that I have may found a bug in PR #45930, (or IF outside of the PR scope, still something that I think should be checked)? When I put the Default Menu in many positions as requested, I found that when it is in below-top position on CASSIOPEIA, I got a bleed through due to an incorrectly or unset z-index...
FYI, (while this may not be HOW you want it fixed, if I add z-index:1 (or higher) to .mod-list li .mod-menu__sub in template.min.css, the issue is resolved... ) |
Co-authored-by: Martina Scholz <64533137+LadySolveig@users.noreply.github.com>
|
I have tested this item ✅ successfully on d4f176a (what I found will be covered in a new PR) This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930. |
|
I have tested this item ✅ successfully on d4f176a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930. |
|
In case anyone is interested: |
@ChristineWk This is a known issue we have observed with 3rd party extensions. Do you have some installed on your site? If yes, which? |
|
To all testers: Have you also checked that the metismenu is not broken? |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930. |
|
The changes are for the standard Joomla menu. It affected Phoca extensions, but it was version 6.0.0-alpha4-dev. I informed Jan about it and therefore copied his changed code (see above) here. It should work with a newer beta version. |
|
@ChristineWk I know that the changes made by this PR here are for the standard menu. But the standard menu and the metismenu might share some class names in the markup, so CSS might be applied on both. |
The requested change (z-index) has been implemented with commit d4f176a .
|
thank you @drmenzelit and @LadySolveig for your code and testing and to the other testers |
* Add CSS for the corrected mod_menu * Corrected focus * Corrected z-index




Summary of Changes
With #45922 the standard view of mod_menu was refactored.
This PR adds some CSS in Cassiopeia to display the menu correctly.
Testing Instructions
Create different menu items, create a menu module with default layout, test it in different positions.
Actual result BEFORE applying this Pull Request
When the menu is in the position "menu" the submenu makes a shift: #45922 (comment)
Expected result AFTER applying this Pull Request
The submenu opens correctly: #45922 (comment)
There is still a problem with focus-visible on the button (off center), but I haven't a good solution by now (we have the same problem also in Metismenu)
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed