[6.0] [webservices] cannot delete not trashed resource return 409

[alikon]

Pull Request for Issue #45590 .

Summary of Changes

return HTTP status code 409 instead of 500
add a system test

Testing Instructions

delete not-trashed resource like: tag, category, article etc via webservices DELETE endpoint

Actual result BEFORE applying this Pull Request

HTTP status code 500 and error message "Internal server error".

Expected result AFTER applying this Pull Request

HTTP status code 409 with informative message like : Resource not in state that can be deleted, must be trashed before it can be deleted

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[exlemor]

I have tested this item ✅ successfully on 9b475e6

I have tested this successfully via Postman! Thanks @alikon (and I confirmed that if you do Trash the article, if does DELETE it as well).

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45868.}

[rbuelund]

I have tested this item ✅ successfully on 4fbb57e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45868.}

[exlemor]

I have tested this item ✅ successfully on 4fbb57e

I have re-tested this successfully ! Thanks @alikon

Same positive results :D

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45868.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45868.}

[richard67]

I've allowed myself to fix the conflict in the ApiController.php file. It was caused by the same line of code being removed with this PR here and with PR #45589 on the 5.3-dev branch. As this did not change anything on the code, RTC is still valid.

[richard67]

@alikon Since the last branch update, system tests are failing for this PR here:

  Running:  api/com_contact/Contacts.cy.js                                              (103 of 148)

  Test that contacts API endpoint
    ✓ can deliver a list of contacts (947ms)
    ✓ can deliver a single contact (97ms)
    ✓ can create a contact (120ms)
    ✓ can update a contact (158ms)
    ✓ can delete a contact (94ms)
    1) check correct response for delete a not existent contact
    ✓ can submit a contact form (291ms)

  6 passing (2s)
  1 failing

  1) Test that contacts API endpoint
       check correct response for delete a not existent contact:
     CypressError: `cy.request()` failed on:

https://localhost/cmysql/api/index.php/v1/contacts/9999
The response we received from your web server was:
  > 500: Internal Server Error

Did I do something wrong when resolving the conflict caused by the upmerged PR #45589 ?

[alikon]

@richard67 all system tests are successful now

[Bodge-IT]

Great work @alikon, thank you. Big thanks to @exlemor & @rbuelund for the tests

[muhme]

Sorry for being late, it has been very busy days ... but I was of course, I am interested to see the fix of my issue 😄

Tested with JBT graft nightly builds and api_500_test.sh:

• for 5.3.4-dev, 5.4.0-dev and 6.0.0-beta2 (as the PR is already merged)
  • ❌ Deleting not-trashed article/content category/tag > 204 (NO CONTENT), but the action failed
  • ✅ Deleting trashed article/content category/tag > 204 (NO CONTENT)
  • ✅ Deleting not-existing article/content category/tag > 204 (NO CONTENT)
• for 6.0.0-dev
  • ✅ Deleting not-trashed article > 409 (CONFLICT), but the API call failed
    • data.message: Resource not in state that can be deleted, must be trashed before it can be deleted
    • messages.warning: Delete not permitted.
  • ✅ Deleting trashed article/content category/tag > 204 (NO CONTENT)
  • ✅ Deleting not-existing article/content category/tag > 204 (NO CONTENT)

Before the PR and tested from 5.3 onwards, deleting an not-trashed item no longer results in a 500, but still results in a wrong 204. This is fixed well 👍

Created #46095

Thank you for extending System Tests with testing to delete not-trashed and not-existing banner 👍