Skip to content

[5.4] Converting DatabaseQuery::castAsChar() to castAs() #45826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muhme merged 2 commits into from
Aug 4, 2025
Merged

[5.4] Converting DatabaseQuery::castAsChar() to castAs() #45826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0b3a81
Converting DatabaseQuery::castAsChar() to castAs()
Hackwar Aug 3, 2025
629a6b4
Merge branch '5.4-dev' into 5.4-castaschar
muhme Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion administrator/components/com_finder/src/Model/IndexModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ protected function getListQuery()

// Filter by indexdate only if $search doesn't contains non-ascii characters
if (!preg_match('/[^\x00-\x7F]/', $search)) {
$orSearchSql .= ' OR ' . $query->castAsChar($db->quoteName('l.indexdate')) . ' LIKE ' . $search;
$orSearchSql .= ' OR ' . $query->castAs('CHAR', $db->quoteName('l.indexdate')) . ' LIKE ' . $search;
}

$query->where('(' . $orSearchSql . ')');
Expand Down
4 changes: 2 additions & 2 deletions components/com_contact/src/Model/CategoryModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,9 +466,9 @@ private function getSlugColumn($query, $id, $alias)
return 'CASE WHEN '
. $query->charLength($alias, '!=', '0')
. ' THEN '
. $query->concatenate([$query->castAsChar($id), $alias], ':')
. $query->concatenate([$query->castAs('CHAR', $id), $alias], ':')
. ' ELSE '
. $query->castAsChar($id) . ' END';
. $query->castAs('CHAR', $id) . ' END';
}

/**
Expand Down
4 changes: 2 additions & 2 deletions components/com_contact/src/Model/ContactModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,9 +403,9 @@ private function getSlugColumn($query, $id, $alias)
return 'CASE WHEN '
. $query->charLength($alias, '!=', '0')
. ' THEN '
. $query->concatenate([$query->castAsChar($id), $alias], ':')
. $query->concatenate([$query->castAs('CHAR', $id), $alias], ':')
. ' ELSE '
. $query->castAsChar($id) . ' END';
. $query->castAs('CHAR', $id) . ' END';
}

/**
Expand Down
4 changes: 2 additions & 2 deletions components/com_content/src/Model/ArchiveModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,8 @@ private function getSlugColumn($query, $id, $alias)
return 'CASE WHEN '
. $query->charLength($db->quoteName($alias), '!=', '0')
. ' THEN '
. $query->concatenate([$query->castAsChar($db->quoteName($id)), $db->quoteName($alias)], ':')
. $query->concatenate([$query->castAs('CHAR', $db->quoteName($id)), $db->quoteName($alias)], ':')
. ' ELSE '
. $query->castAsChar($id) . ' END';
. $query->castAs('CHAR', $id) . ' END';
}
}
2 changes: 1 addition & 1 deletion libraries/src/Categories/Categories.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ protected function _load($id)
$case_when = ' CASE WHEN ';
$case_when .= $query->charLength($db->quoteName('c.alias'), '!=', '0');
$case_when .= ' THEN ';
$c_id = $query->castAsChar($db->quoteName('c.id'));
$c_id = $query->castAs('CHAR', $db->quoteName('c.id'));
$case_when .= $query->concatenate([$c_id, $db->quoteName('c.alias')], ':');
$case_when .= ' ELSE ';
$case_when .= $c_id . ' END as ' . $db->quoteName('slug');
Expand Down
8 changes: 4 additions & 4 deletions plugins/content/pagenavigation/src/Extension/PageNavigation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,12 @@ public function onContentBeforeDisplay(BeforeDisplayEvent $event)
$query->order($orderby);

$case_when = ' CASE WHEN ' . $query->charLength($db->quoteName('a.alias'), '!=', '0')
. ' THEN ' . $query->concatenate([$query->castAsChar($db->quoteName('a.id')), $db->quoteName('a.alias')], ':')
. ' ELSE ' . $query->castAsChar('a.id') . ' END AS ' . $db->quoteName('slug');
. ' THEN ' . $query->concatenate([$query->castAs('CHAR', $db->quoteName('a.id')), $db->quoteName('a.alias')], ':')
. ' ELSE ' . $query->castAs('CHAR', 'a.id') . ' END AS ' . $db->quoteName('slug');

$case_when1 = ' CASE WHEN ' . $query->charLength($db->quoteName('cc.alias'), '!=', '0')
. ' THEN ' . $query->concatenate([$query->castAsChar($db->quoteName('cc.id')), $db->quoteName('cc.alias')], ':')
. ' ELSE ' . $query->castAsChar('cc.id') . ' END AS ' . $db->quoteName('catslug');
. ' THEN ' . $query->concatenate([$query->castAs('CHAR', $db->quoteName('cc.id')), $db->quoteName('cc.alias')], ':')
. ' ELSE ' . $query->castAs('CHAR', 'cc.id') . ' END AS ' . $db->quoteName('catslug');

$query->select($db->quoteName(['a.id', 'a.title', 'a.catid', 'a.language']))
->select([$case_when, $case_when1])
Expand Down
2 changes: 1 addition & 1 deletion plugins/finder/categories/src/Extension/Categories.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ protected function getListQuery($query = null)
$case_when_item_alias = ' CASE WHEN ';
$case_when_item_alias .= $query->charLength($db->quoteName('a.alias'), '!=', '0');
$case_when_item_alias .= ' THEN ';
$a_id = $query->castAsChar($db->quoteName('a.id'));
$a_id = $query->castAs('CHAR', $db->quoteName('a.id'));
$case_when_item_alias .= $query->concatenate([$a_id, 'a.alias'], ':');
$case_when_item_alias .= ' ELSE ';
$case_when_item_alias .= $a_id . ' END AS slug';
Expand Down
4 changes: 2 additions & 2 deletions plugins/finder/contacts/src/Extension/Contacts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ protected function getListQuery($query = null)
$case_when_item_alias = ' CASE WHEN ';
$case_when_item_alias .= $query->charLength('a.alias', '!=', '0');
$case_when_item_alias .= ' THEN ';
$a_id = $query->castAsChar('a.id');
$a_id = $query->castAs('CHAR', 'a.id');
$case_when_item_alias .= $query->concatenate([$a_id, 'a.alias'], ':');
$case_when_item_alias .= ' ELSE ';
$case_when_item_alias .= $a_id . ' END as slug';
Expand All @@ -456,7 +456,7 @@ protected function getListQuery($query = null)
$case_when_category_alias = ' CASE WHEN ';
$case_when_category_alias .= $query->charLength('c.alias', '!=', '0');
$case_when_category_alias .= ' THEN ';
$c_id = $query->castAsChar('c.id');
$c_id = $query->castAs('CHAR', 'c.id');
$case_when_category_alias .= $query->concatenate([$c_id, 'c.alias'], ':');
$case_when_category_alias .= ' ELSE ';
$case_when_category_alias .= $c_id . ' END as catslug';
Expand Down
4 changes: 2 additions & 2 deletions plugins/finder/content/src/Extension/Content.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ protected function getListQuery($query = null)
$case_when_item_alias = ' CASE WHEN ';
$case_when_item_alias .= $query->charLength('a.alias', '!=', '0');
$case_when_item_alias .= ' THEN ';
$a_id = $query->castAsChar('a.id');
$a_id = $query->castAs('CHAR', 'a.id');
$case_when_item_alias .= $query->concatenate([$a_id, 'a.alias'], ':');
$case_when_item_alias .= ' ELSE ';
$case_when_item_alias .= $a_id . ' END as slug';
Expand All @@ -403,7 +403,7 @@ protected function getListQuery($query = null)
$case_when_category_alias = ' CASE WHEN ';
$case_when_category_alias .= $query->charLength('c.alias', '!=', '0');
$case_when_category_alias .= ' THEN ';
$c_id = $query->castAsChar('c.id');
$c_id = $query->castAs('CHAR', 'c.id');
$case_when_category_alias .= $query->concatenate([$c_id, 'c.alias'], ':');
$case_when_category_alias .= ' ELSE ';
$case_when_category_alias .= $c_id . ' END as catslug';
Expand Down
4 changes: 2 additions & 2 deletions plugins/finder/newsfeeds/src/Extension/Newsfeeds.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ protected function getListQuery($query = null)
$case_when_item_alias = ' CASE WHEN ';
$case_when_item_alias .= $query->charLength('a.alias', '!=', '0');
$case_when_item_alias .= ' THEN ';
$a_id = $query->castAsChar('a.id');
$a_id = $query->castAs('CHAR', 'a.id');
$case_when_item_alias .= $query->concatenate([$a_id, 'a.alias'], ':');
$case_when_item_alias .= ' ELSE ';
$case_when_item_alias .= $a_id . ' END as slug';
Expand All @@ -384,7 +384,7 @@ protected function getListQuery($query = null)
$case_when_category_alias = ' CASE WHEN ';
$case_when_category_alias .= $query->charLength('c.alias', '!=', '0');
$case_when_category_alias .= ' THEN ';
$c_id = $query->castAsChar('c.id');
$c_id = $query->castAs('CHAR', 'c.id');
$case_when_category_alias .= $query->concatenate([$c_id, 'c.alias'], ':');
$case_when_category_alias .= ' ELSE ';
$case_when_category_alias .= $c_id . ' END as catslug';
Expand Down
2 changes: 1 addition & 1 deletion plugins/finder/tags/src/Extension/Tags.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ protected function getListQuery($query = null)
$case_when_item_alias = ' CASE WHEN ';
$case_when_item_alias .= $query->charLength('a.alias', '!=', '0');
$case_when_item_alias .= ' THEN ';
$a_id = $query->castAsChar('a.id');
$a_id = $query->castAs('CHAR', 'a.id');
$case_when_item_alias .= $query->concatenate([$a_id, 'a.alias'], ':');
$case_when_item_alias .= ' ELSE ';
$case_when_item_alias .= $a_id . ' END as slug';
Expand Down
Loading