[6.0] Convert Popular Module to Service

[rdeutz]

Summary of Changes

We want to get rid of static helpers and the use super globals, this module is one of the latest modules working in the old way. The PR converts it (leaving the dark side).

Testing Instructions

Check if the module is behaving in the same way as it was before the PR

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[exlemor]

I have tested this item ✅ successfully on 0966f7e

I have successfully tested this PR. Thanks @rdeutz!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45808.}

[RickR2H]

I have tested this item ✅ successfully on 0966f7e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45808.}

[RickR2H]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45808.}

[brianteeman]

Please deprecate the unused language string MOD_POPULAR_NO_MATCHING_RESULTS

[rdeutz]

Please deprecate the unused language string MOD_POPULAR_NO_MATCHING_RESULTS

done, fun part it was never used.

[rdeutz]

RTC state still valid

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45808.}

[brianteeman]

Please deprecate the unused language string MOD_POPULAR_NO_MATCHING_RESULTS

done, fun part it was never used.

but it should have been as the modules are misusing the emtpystate see details #45810

[rdeutz]

as the modules are misusing the emtpystate

I would agree to that statement, but I don't want to pull that problem into the scope of this PR.

[brianteeman]

thats why i created a new issue

[softforge]

Thanks to all who worked on this PR, your work is appreciated