Add moduleclass_sfx param to custom module template#45749
Closed
mgscreativa wants to merge 1 commit intojoomla:5.3-devfrom
Closed
Add moduleclass_sfx param to custom module template#45749mgscreativa wants to merge 1 commit intojoomla:5.3-devfrom
mgscreativa wants to merge 1 commit intojoomla:5.3-devfrom
Conversation
Contributor
|
This is not correct. The module class suffix is added by the module chrome. If you are not seeing this in your own template then you need to set the correct module chrome |
Contributor
|
Thank you for your Pull Request, really appreciate that you contributed. As Brian said, the suffix should be managed by the chrome and was changed here by purpose: So I will close this PR but I hope you don't feel discouraged by this and continue contributing. Thank you for your effort! |
Author
|
Ok, so the $params->get('moduleclass_sfx should be at the chrome implementation? |
Contributor
|
You can see an example here: https://github.com/joomla/joomla-cms/blob/5.3-dev/layouts/chromes/html5.php#L27 |
Author
|
Cool, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed