Skip to content

Add moduleclass_sfx param to custom module template#45749

Closed
mgscreativa wants to merge 1 commit intojoomla:5.3-devfrom
mgscreativa:5.3-dev
Closed

Add moduleclass_sfx param to custom module template#45749
mgscreativa wants to merge 1 commit intojoomla:5.3-devfrom
mgscreativa:5.3-dev

Conversation

@mgscreativa
Copy link

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

This is not correct. The module class suffix is added by the module chrome. If you are not seeing this in your own template then you need to set the correct module chrome

@bembelimen
Copy link
Contributor

bembelimen commented Jul 23, 2025

Thank you for your Pull Request, really appreciate that you contributed.

As Brian said, the suffix should be managed by the chrome and was changed here by purpose:

#17447

So I will close this PR but I hope you don't feel discouraged by this and continue contributing.

Thank you for your effort!

@bembelimen bembelimen closed this Jul 23, 2025
@mgscreativa
Copy link
Author

Ok, so the $params->get('moduleclass_sfx should be at the chrome implementation?

@chmst
Copy link
Contributor

chmst commented Jul 25, 2025

@mgscreativa
Copy link
Author

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants