[5.3] Debug plugin Collector

[brianteeman]

Pull Request for Issue #45741 .

Summary of Changes

Only display the OpenHandler Icon when the option "Track Request History" is enabled in the system debug plugin.

If the option is not enabled AND there are no previously cached query results clicking on the icon produces

Checking the browser console shows

With this change the icon is only displayed if the option is enabled

Updated

Additionally replaces the php icon with the joomla icon for consistency with the parent windoe

Testing Instructions

Enable the debug plugin with the default settings (Track Request History" is not enabled by default)

Check that the Joomla Cache does not indicate the presence of any cached queries. If it does then delete them

Actual result BEFORE applying this Pull Request

1. Icon is displayed and produces the silent console errors as described above

2. php icon is displayed

Expected result AFTER applying this Pull Request

1. Icon is not displayed

2. Re test with the option enabled and the icon is displayed and you are able to select from the history.

3. joomla icon is displayed

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[heelc29]

I have tested this item ✅ successfully on 74b7091

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45747.}

[exlemor]

@brianteeman my AFTER condition matches perfectly, my BEFORE condition with 1 small difference:

The error I get says: Unhandled Promise Rejection: TypeError: Load failed (in Safari 18.5) - could the browser used give a slightly different error message?

Based on your previous comments, you have said if it doesn't match 100% you can't consider a good test so that's why I am checking.

[brianteeman]

so the icon is NOT displayed after applying the pr except when the option is enabled?

and when the option is enabled and you click on the icon you get the error?

Is there anything in the folders administrator\cache\plg_system_debug_administrator or administrator\cache\plg_system_debug_site

[exlemor]

so the icon is NOT displayed after applying the pr except when the option is enabled?

and when the option is enabled and you click on the icon you get the error?

Is there anything in the folders administrator\cache\plg_system_debug_administrator or administrator\cache\plg_system_debug_site

Hi Brian,

Correct, the icon is NOT displayed after applying the PR except when the option in enabled (which is what I understood from your description is the correct result... hopefully I got that right.)

and yes, when the option is enabled, and click on the icon I get that error.

yes there are files in the administrator\cache\plg_system_debug_administrator folder about 13 files with random numbers/letters all starting with X ---> such as Xc05be07d6242b206322682c6a6d013f6.php each measuring 38kb - 73kb

Hope that helps.

[brianteeman]

sorry just re-read. It is the before condition that gave an error but the error is gone afterwards. Safari console probably gives a slightly different message. The important part of this PR is that there was an error before. There is now no icon so you can never get to the page when the files dont exist so the error condition is never met.

the pr could probably be improved to change the js to give a cleaner error but removing the option has the same effect as you can never get to the page producing the error

[exlemor]

sorry just re-read. It is the before condition that gave an error but the error is gone afterwards. Safari console probably gives a slightly different message. The important part of this PR is that there was an error before. There is now no icon so you can never get to the page when the files dont exist so the error condition is never met.

the pr could probably be improved to change the js to give a cleaner error but removing the option has the same effect as you can never get to the page producing the error

Yes, it is behaving as you planned it - the only 'difference' was the error message but if you say that Safari probably gives a slightly different message then that appeases my concern. What browser did you test against so if I have a bit of time I can redo the test with that browser and confirm the same error message which would confirm that Safari uses a slightly different error message.

[brianteeman]

chrome on windows -the error messages have the same meaning - as long as you dont get an error with this pr then its fine

[ceford]

I have tested this item ✅ successfully on 74b7091

I discovered that folder icon recently and found the only way to get rid of the pop-up box was to reload the page. Glad to see it absent.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45747.}

[richard67]

the only way to get rid of the pop-up box was to reload the page.

@ceford Simply clicking with the mouse to another place of the page outside of the modal will close it. Not sure though how it works with keyboard navigation.

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45747.}

[rdeutz]

Thanks