Skip to content

[5.3] - Installation - Fix .bg-warning text color for accessibility#45717

Merged
rdeutz merged 2 commits intojoomla:5.3-devfrom
travisrisner:installation-warning-color
Jul 15, 2025
Merged

[5.3] - Installation - Fix .bg-warning text color for accessibility#45717
rdeutz merged 2 commits intojoomla:5.3-devfrom
travisrisner:installation-warning-color

Conversation

@travisrisner
Copy link
Contributor

Pull Request for Issue #45698.

Summary of Changes

  • Changed the hardcoded color: #fff (white text) to color: #000 (black text) for .bg-warning in the installation template SCSS.
  • Ensures the warning background now has black text for proper contrast and accessibility compliance.

Testing Instructions

  1. Run Joomla installation and observe any element using the .bg-warning class.
  2. Confirm that the text appears black on the warning background (instead of white).
  3. Check that contrast passes accessibility guidelines.

Actual result BEFORE applying this Pull Request

  • .bg-warning text color was hardcoded as white, causing accessibility contrast failures on warning backgrounds during installation.

Expected result AFTER applying this Pull Request

  • .bg-warning text color is now black, providing sufficient contrast and passing accessibility checks during installation.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Jul 11, 2025
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 660cbc4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45717.

1 similar comment
@QuyTon
Copy link
Contributor

QuyTon commented Jul 14, 2025

I have tested this item ✅ successfully on 660cbc4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45717.

@QuyTon
Copy link
Contributor

QuyTon commented Jul 14, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45717.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 14, 2025
@rdeutz rdeutz enabled auto-merge (squash) July 15, 2025 08:28
@rdeutz rdeutz merged commit 4b7ed80 into joomla:5.3-dev Jul 15, 2025
32 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 15, 2025
@richard67 richard67 added this to the Joomla! 5.3.3 milestone Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments