[5.3] Github Actions: Automatic codestyle fixes for PRs #45652
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add phpstan to github action * Update ci.yml * Update ci.yml
|
Can we somehow test this before it gets merged? |
|
It has to be first in a branch of the target repo and then we would have to create a PR which has some broken codestyle. So, to be honest, I would rather merge this first and in worst case revert it later. |
|
for such things we can use another branch and play there |
|
So basically a pr against Hackwar:ghactions-codestyle would be enough for testing. Or? |
|
You might be right. 😄 |
brianteeman
reviewed
Jul 25, 2025
4 tasks
Hackwar
force-pushed
the
ghactions-codestyle
branch
from
53ceade to
1598de7
Compare
|
Unfortunately this doesn't feel stable and reliable enough for us to use right now. Thus I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR implements automatic codestyle fixes to pull requests. When a PR does not have the right codestyle, this will create suggestions to fix it.