[5.3] Migrating Appveyor tests to Github Actions #45651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add phpstan to github action * Update ci.yml * Update ci.yml
laoneo
reviewed
Jun 25, 2025
Member
|
To have LDAP support, you need to start it after checkout because the certificates are only available after the checkout action was run as I did here. |
Member
Author
|
There is no container in windows runners. So you can't run a docker container in a windows runner. That would mean that we would have to first install openLDAP from somewhere like we do in Appveyor. I didn't want to run the installation of Appveyor for this and couldn't find a working openLDAP action for Windows. |
Member
|
Thanks! |
2 tasks
heelc29
added a commit
to heelc29/joomla-cms
that referenced
this pull request
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
What the title says. Please notice that this disables the ldap tests for Windows right now, since I couldn't get an LDAP server running.