[5.3] Login Module show password#45626
Merged
rdeutz merged 3 commits intojoomla:5.3-devfrom Jun 20, 2025
Merged
Conversation
Member
|
If it is a bug fix, why is it made for 5.4-dev and not for 5.3-dev? I'm ok with having it in 5.4, but it is still a while until we go stable with it, so people have to wait for that fix. |
brianteeman
changed the title
The login module password field has a button to reveal the password (change from *) Signed-off-by: BrianTeeman <brian@teeman.net>
brianteeman
force-pushed
the
login_module
branch
from
4d9756d to
146a6e9
Compare
Contributor
Author
|
rebased to 5.3 |
richard67
approved these changes
Jun 19, 2025
Member
|
I have tested this item ✅ successfully on 146a6e9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45626. |
|
I have tested this item ✅ successfully on d4f899a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45626. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45626. |
Contributor
|
Thanks |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The login module password field has a button to reveal the password (change from *) however this button is not present if you have set the module to display labels. This PR fixes that.
Testing Instructions
Create a login module for the site and set the option Display Labels to Text
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed