Conversation
Contributor
|
nice work |
Member
|
Why are you running the system tests on chrome and not Firefox like right now? |
Hackwar
reviewed
Jun 20, 2025
Hackwar
reviewed
Jun 20, 2025
Member
Author
|
On GH is only chrome available. Can't find the issue right now, but firefox was not working. |
* Add phpstan to github action * Update ci.yml * Update ci.yml
Member
|
Since we are using our own docker image for the cypress tests, firefox should still be available. |
Member
Author
|
The install task of cypress adds the browsers, they are not in the image. |
Contributor
|
Thanks! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds a Github workflow file which does the same code style checks and testing as we do now in drone, but with chrome and edge browsers. Firefox is currently not supported. An additional parameter is added to the entrypoint file to define the browser to run.