Skip to content

[5.3] Remove Fields button for custom module#45600

Merged
rdeutz merged 5 commits intojoomla:5.3-devfrom
brianteeman:fields_module
Jun 19, 2025
Merged

[5.3] Remove Fields button for custom module#45600
rdeutz merged 5 commits intojoomla:5.3-devfrom
brianteeman:fields_module

Conversation

@brianteeman
Copy link
Contributor

Summary of Changes

This PR removes the Fields button from the custom HTML module as it cannot be used here and should not be presented

Testing Instructions

Test with both the editor set to tinymce and with the editor set to none. When set to tinymce the buttons are in the CMS Content Dropdown. When set to any other editor the buttons are below the text area

Make sure to test front end module editing as well

Actual result BEFORE applying this Pull Request

image

image

Expected result AFTER applying this Pull Request

image

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

This PR removes the Fields button from the custom HTML module as it cannot be used here and should not be presented

Signed-off-by: BrianTeeman <brian@teeman.net>
@chmst
Copy link
Contributor

chmst commented Jun 12, 2025

Changes in the hide attribute work as expected.

I am wondering about the labels.
They are not used at all, changing to _LABEL1 has no effect but is not in the Language file.

@brianteeman
Copy link
Contributor Author

Changes in the hide attribute work as expected.

I am wondering about the labels. They are not used at all, changing to _LABEL1 has no effect but is not in the Language file.

sorry that was a remnant from testing

@chmst
Copy link
Contributor

chmst commented Jun 12, 2025

I have tested this item ✅ successfully on 55132e0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45600.

@web-eau-net
Copy link

I have tested this item ✅ successfully on 55132e0

Thank you


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45600.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45600.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 12, 2025
@rdeutz rdeutz merged commit 61f4c77 into joomla:5.3-dev Jun 19, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 19, 2025
@rdeutz
Copy link
Contributor

rdeutz commented Jun 19, 2025

Thanks

@brianteeman brianteeman deleted the fields_module branch June 19, 2025 16:45
@QuyTon QuyTon added this to the Joomla! 5.3.2 milestone Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

Comments