[5.3] Remove Fields button for custom module#45600
Merged
rdeutz merged 5 commits intojoomla:5.3-devfrom Jun 19, 2025
Merged
Conversation
This PR removes the Fields button from the custom HTML module as it cannot be used here and should not be presented Signed-off-by: BrianTeeman <brian@teeman.net>
Contributor
|
Changes in the hide attribute work as expected. I am wondering about the labels. |
Contributor
Author
sorry that was a remnant from testing |
Contributor
|
I have tested this item ✅ successfully on 55132e0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45600. |
|
I have tested this item ✅ successfully on 55132e0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45600. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45600. |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR removes the Fields button from the custom HTML module as it cannot be used here and should not be presented
Testing Instructions
Test with both the editor set to tinymce and with the editor set to none. When set to tinymce the buttons are in the CMS Content Dropdown. When set to any other editor the buttons are below the text area
Make sure to test front end module editing as well
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed