Skip to content

[5.3] Banners - Enforce Unique Alias on Both Create and Update #45599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdeutz merged 8 commits into from
Aug 25, 2025
Merged

[5.3] Banners - Enforce Unique Alias on Both Create and Update #45599

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e140d9b
move alias outside of insert and update logic
travisrisner Jun 12, 2025
8fc1fc5
remove whitespace
travisrisner Jun 12, 2025
fd48df9
remove whitespace
travisrisner Jun 12, 2025
52a4e3f
Merge branch '5.3-dev' into banner-alias-fix
rdeutz Jun 25, 2025
2d40179
Merge branch '5.3-dev' into banner-alias-fix
travisrisner Jul 25, 2025
f6a6f8d
Merge branch '5.3-dev' into banner-alias-fix
muhme Aug 1, 2025
4a442fe
Merge branch '5.3-dev' into banner-alias-fix
richard67 Aug 23, 2025
ee2c066
Merge branch '5.3-dev' into banner-alias-fix
rdeutz Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions administrator/components/com_banners/src/Table/BannerTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,15 @@ public function store($updateNulls = true)
{
$db = $this->getDbo();

// Verify that the alias is unique
$table = new self($db, $this->getDispatcher());

if ($table->load(['alias' => $this->alias, 'catid' => $this->catid]) && ($table->id != $this->id || $this->id == 0)) {
$this->setError(Text::_('COM_BANNERS_ERROR_UNIQUE_ALIAS'));

return false;
}

if (empty($this->id)) {
$purchaseType = $this->purchase_type;

Expand Down Expand Up @@ -261,15 +270,6 @@ public function store($updateNulls = true)
$this->setError($oldrow->getError());
}

// Verify that the alias is unique
$table = new self($db, $this->getDispatcher());

if ($table->load(['alias' => $this->alias, 'catid' => $this->catid]) && ($table->id != $this->id || $this->id == 0)) {
$this->setError(Text::_('COM_BANNERS_ERROR_UNIQUE_ALIAS'));

return false;
}

// Store the new row
parent::store($updateNulls);

Expand Down
Loading